Conversation
Document the -Wa,-mbig-obj Windows compilation NOTE in cran-comments.md and make the explanation durable by writing it into src/Makevars.win via configure.win (the actual generator), since manual edits to Makevars.win are overwritten on every build. Also add skip_on_cran() to the Stan-fitting tests in test-run_model.R so CRAN's check run doesn't pay for full model sampling. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
csmith701
force-pushed
the
cran-notes
branch
from
September 23, 2026 16:31
8122d19 to
c91b394
Compare
pearsonca
approved these changes
Sep 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Wa,-mbig-obj"non-portable flags" NOTE incran-comments.md, and make the flag's explanatory comment durable by writing it viaconfigure.win(the actual generator ofsrc/Makevars.win) instead of editing the generated file directly, since manual edits there are silently overwritten on every build.skip_on_cran()to the three Stan-fittingtest_that()blocks intests/testthat/test-run_model.R(following the existing precedent intest-rename_chains.R) to resolve the "checking tests ... NOTE" caused by real model sampling running during CRAN's check (previously ~49 CPU-minutes / ~2 elapsed minutes). The lightweight smoke test intest-hestia-smoke.Ris intentionally left running on CRAN as an end-to-end sanity check.Test plan
just testrun locally: 0 failures, 131 passed, 15 warnings (expected Stan sampler diagnostics from short test chains), 0 skipped (devtools::test()setsNOT_CRAN=true, so the newskip_on_cran()guards only take effect on CRAN's own check run).R CMD check --as-cranto confirm the two targeted NOTEs no longer appear (or are now documented/justified).🤖 Generated with Claude Code