Fix ERA5 DATM shortwave band handling.#7
Open
ezhilsabareesh8 wants to merge 2 commits into
Open
Conversation
Collaborator
|
@NickSzapiro-NOAA - does UFS use the ERA5 datamode in CDEPS ? We've found these lines to calculate sw in vis/ifrared/direct/diffuse bands don't work and the resulting incoming shortwave is much too low. |
|
Yes ... but I think those lines are essentially unused as variables are overwritten in the The changes here look similar to ESCOMP#396 , fyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERA5
ssrdis an accumulated energy field inJ m-2, while MOM/CICE require shortwave band fluxes inW m-2. The previous ERA5 datamode incorrectly treated albedo-like stream fields as shortwave flux bands, producing near-zero shortwave reaching MOM/CICE.This PR:
ssrdto flux with/ 3600.Faxa_swvdr,Faxa_swndr,Faxa_swvdf, andFaxa_swndffrom fixed physical partitions ofssrd_flux.Specific notes
CDEPS Issues Fixed (include github issue #): ACCESS-NRI/access-om3-configs#548 (comment)
Any User Interface Changes (namelist or namelist defaults changes): Changes made in datm.streams.xml and generate_xml_datm_era5.py