Skip to content

chore: sync ship-binary versions + NSIS PRODUCT_VERSION to 0.12.1 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-EION merged 2 commits into from
May 21, 2026
+18 −6
Merged

chore: sync ship-binary versions + NSIS PRODUCT_VERSION to 0.12.1 #17

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df0b636
chore: sync ship-binary versions + NSIS PRODUCT_VERSION to 0.12.1
May 21, 2026
744da89
Address PR #17 review: use workspace.version inheritance
May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion installer/maxima-setup.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
!define PRODUCT_NAME "Maxima"
!define PRODUCT_PUBLISHER "Armchair Developers"
!define PRODUCT_WEB_SITE "https://github.com/ArmchairDevelopers/Maxima"
!define PRODUCT_VERSION "0.5.0"
!define PRODUCT_VERSION "0.12.1"
!define PRODUCT_UNINST_KEY "Software\Microsoft\Windows\CurrentVersion\Uninstall\${PRODUCT_NAME}"
!define PRODUCT_UNINST_ROOT_KEY "HKLM"

Expand Down
2 changes: 1 addition & 1 deletion maxima-bootstrap/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "maxima-bootstrap"
description = "Maxima handler for custom EA protocols"
version = "0.6.0"
version = "0.12.1"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To prevent future version drift (as noted in the PR description where some components were stuck at 0.1.0 or 0.6.0), consider using workspace inheritance. By defining the version once in the root Cargo.toml under [workspace.package] and using version.workspace = true in the member crates, you ensure all components stay in sync automatically. This pattern can also be applied to common dependencies (like tokio, serde, clap, etc.) to maintain consistency across the workspace.

authors = ["Sean Kahler <sean@battleda.sh>"]
edition = "2021"

Expand Down
2 changes: 1 addition & 1 deletion maxima-cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "maxima-cli"
version = "0.6.0"
version = "0.12.1"
authors = ["Sean Kahler <sean@battleda.sh>"]
edition = "2021"

Expand Down
2 changes: 1 addition & 1 deletion maxima-service/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "maxima-service"
version = "0.6.0"
version = "0.12.1"
authors = ["Sean Kahler <sean@battleda.sh>"]
edition = "2021"

Expand Down
2 changes: 1 addition & 1 deletion maxima-tui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "maxima-tui"
version = "0.1.0"
version = "0.12.1"
authors = ["Sean Kahler <sean@battleda.sh>"]
edition = "2021"

Expand Down
2 changes: 1 addition & 1 deletion maxima-ui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "maxima-ui"
version = "0.1.0"
version = "0.12.1"
authors = ["Nick Whelan <cooldood909@gmail.com>"]
edition = "2021"

Expand Down
Loading