fix(settings): restore compact save action chip - #1186
Conversation
|
@greptileai Please review this pull request, with particular attention to the compact Settings save-action chip, sticky positioning, blur surface sizing, content overlap, and Electron layout regressions. |
Greptile SummaryThis PR restores the settings save action from a full-width sticky footer back to a compact floating chip, and fixes a responsive layout bug where
Confidence Score: 5/5Safe to merge — the changes are a well-scoped CSS restoration with a direct E2E regression guard running at the exact breakpoint being fixed. The three-file change restores two CSS variables, reverts the action-bar styling to the compact chip, and removes the No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["--settings-action-bar-offset: 24px\n--settings-action-bar-space: 112px\n(_settings-theme.scss)"] --> B
B[".settings-layout\npadding-bottom: calc(\n --settings-action-bar-space +\n --settings-safe-bottom\n)"]
C["@media (max-width: 1100px)\n.settings-layout { max-width: 100% }\n✅ padding: 0 REMOVED"]
B --> D{".settings-container\n.dialog-mode?"}
C -.->|"previously zeroed padding-bottom\nnow removed"| B
D -->|"Yes"| E[".settings-layout\npadding-bottom: 0\naction-bar: position static\nalign-self: stretch"]
D -->|"No"| F[".action-bar\nposition: sticky\nbottom: 24px + safe-area\nmargin-left: auto\nborder-radius: 18px\nborder: 1px solid"]
F --> G["Chip stays visible while scrolling\nFinal row never covered ✓"]
E --> H["Full-width static bar in dialog ✓"]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["--settings-action-bar-offset: 24px\n--settings-action-bar-space: 112px\n(_settings-theme.scss)"] --> B
B[".settings-layout\npadding-bottom: calc(\n --settings-action-bar-space +\n --settings-safe-bottom\n)"]
C["@media (max-width: 1100px)\n.settings-layout { max-width: 100% }\n✅ padding: 0 REMOVED"]
B --> D{".settings-container\n.dialog-mode?"}
C -.->|"previously zeroed padding-bottom\nnow removed"| B
D -->|"Yes"| E[".settings-layout\npadding-bottom: 0\naction-bar: position static\nalign-self: stretch"]
D -->|"No"| F[".action-bar\nposition: sticky\nbottom: 24px + safe-area\nmargin-left: auto\nborder-radius: 18px\nborder: 1px solid"]
F --> G["Chip stays visible while scrolling\nFinal row never covered ✓"]
E --> H["Full-width static bar in dialog ✓"]
Reviews (3): Last reviewed commit: "fix(settings): preserve sticky action sp..." | Re-trigger Greptile |
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #1186 +/- ##
===========================================
- Coverage 71.05% 59.02% -12.03%
===========================================
Files 40 593 +553
Lines 691 34271 +33580
Branches 87 7743 +7656
===========================================
+ Hits 491 20230 +19739
- Misses 176 11096 +10920
- Partials 24 2945 +2921
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@greptileai please re-review the latest settings follow-up. The responsive layout now preserves sticky action spacing at <=1100px, with deterministic Electron E2E coverage at 1000x760. |
What changed
Root cause
The save action had been changed from a floating chip into a full-width sticky footer. That made its blur surface much larger than the action itself and removed the intended spacing from the bottom edge.
User impact
The save action remains sticky and easy to reach, but its background and blur are limited to a compact chip instead of spanning the entire Settings content width.
Validation
pnpm nx run electron-backend-e2e:e2e-ci--src/settings-layout.e2e.ts(1 passed on the isolated fix branch)pnpm nx run electron-backend-e2e:e2e-ci--src/settings.e2e.ts(8 passed before branch extraction)pnpm nx lint electron-backend-e2e(0 errors; existing warnings only)git diff --check