Skip to content

Add Harry Potter and The Sorcerers Stone - #50

Open
goore3 wants to merge 1 commit into
404minds:masterfrom
goore3:master
Open

Add Harry Potter and The Sorcerers Stone#50
goore3 wants to merge 1 commit into
404minds:masterfrom
goore3:master

Conversation

@goore3

@goore3 goore3 commented Oct 2, 2019

Copy link
Copy Markdown

Proposed Changes

  • I've read the CODE OF CONDUCT and abide to it.
  • I've read the CONTRIBUTING.md
  • I've forked the repository.
  • I've created a branch and made my changes in it.
  • I understand opening a PULL REQUEST doesn't mean it will be merged for sure.

Fixes issue

Fixes #40

@goore3 goore3 changed the title Create hp-sorcerers-stone.json Add Harry Potter and The Sorcerers Stone Oct 2, 2019
"ISBN": " 0747532699",
"language": "english",
"publisher": "Bloomsbury",
"publication_date": "26-06-97"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publication_date is incorrect. It should be in the following format:

"publication_date": "1946-06-08"

"genres": ["Fantasy Fiction, Young Adult Fiction"],
"characters": ["Harry Potter", "Albus Dumbledore", "Rubeus Hagrid", "Hermiona Granger", "Ron Weasley"],
"pages": 223,
"ISBN": " 0747532699",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISBN number has blank spaces. Please remove those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add book Harry Potter and the Sorcerer's Stone

2 participants