Repository navigation
Add a .distignore to keep dev tooling out of the release archive - #16
Merged
Merged
Conversation
`wp dist-archive` has no fallback when no `.distignore` is present: it packages every file in the directory. With neither `.distignore` nor `.gitattributes` in the repository, the archive built by the Plugin Check workflow therefore contained `.git/`, `.github/`, `.wordpress-org/` and `phpcs.xml` — exactly the hidden files the check flags — and, when the workflow is run locally with `act` (which copies the whole working tree instead of doing a clean checkout), also `vendor/`, `node_modules/`, `artifacts/` and `.phpunit.result.cache`. List the development and CI tooling explicitly so the archive holds only `language-fallback.php` and `readme.txt`. This makes the comment in `.github/workflows/wordpress-plugin-check.yml` about a `.distignore`-driven build accurate, and aligns the checked archive with what `10up/action-wordpress-plugin-deploy` actually ships to wordpress.org. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (1)📁 language-fallback.php (1 error)
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wp dist-archivehas no fallback when no.distignoreis present: it packages every file in the directory. With neither.distignorenor.gitattributesin the repository, the archive built by the Plugin Check workflow therefore contained.git/,.github/,.wordpress-org/andphpcs.xml— exactly the hidden files the check flags — and, when the workflow is run locally withact(which copies the whole working tree instead of doing a clean checkout), alsovendor/,node_modules/,artifacts/and.phpunit.result.cache.List the development and CI tooling explicitly so the archive holds only
language-fallback.phpandreadme.txt. This makes the comment in.github/workflows/wordpress-plugin-check.ymlabout a.distignore-driven build accurate, and aligns the checked archive with what10up/action-wordpress-plugin-deployactually ships to wordpress.org.Verified locally with
wp dist-archive ., which now produces an archive containing exactlylanguage-fallback/language-fallback.phpandlanguage-fallback/readme.txt.🤖 Generated with Claude Code