Fix items duplication in prev sector on entering new sector#551
Draft
steph-pg wants to merge 2 commits into1dot13:masterfrom
Draft
Fix items duplication in prev sector on entering new sector#551steph-pg wants to merge 2 commits into1dot13:masterfrom
steph-pg wants to merge 2 commits into1dot13:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should fix a rather annoying bug with items duplication when you reorder items in one sector and then you enter a non selected sector. It was introduced in f88b07b and I found it using bisect so what ever was fixed there could potential come up. My limited testing shows no duplications so far. If there is more to it you have you're starting point I guess.
UPD: Had an opportunity to play a bit. Dups are still there but steps to reproduces are now different... I'll try to revert the whole f88b07b and test how it goes
UPD2: Since debugging world inventory is an absolute pain this is a quick and dirty way to make it work. No dups so far. Game can be saved and loaded