Fix: Disable post cache for cross-site queries - #4353
Open
burhandodhy wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
On multisite, cross-site Elasticsearch queries (
site__in,site__not_in, orep_search_scope→all) could prime the blog-specific posts cache with posts from other sites. Because that cache is keyed by post ID only, a laterget_post()for a local ID could return another site's content.This change disables
cache_resultsfor those cross-site query scopes inget_es_posts(), after the final scope is resolved.Closes #4352
How to test the Change
Changelog Entry
Credits
Props @burhandodhy @dannyreaktiv
Checklist: