chore: remove unmaintained daemonize crate (RUSTSEC-2025-0069)#90
Conversation
Agent-Logs-Url: https://github.com/100monkeys-ai/aegis-orchestrator/sessions/d9a9c56b-b68e-416f-91b2-4443f08698e2 Co-authored-by: Theaxiom <57013+Theaxiom@users.noreply.github.com>
daemonize crate (RUSTSEC-2025-0069)
659df8b to
e5830fb
Compare
There was a problem hiding this comment.
Pull request overview
Removes an unmaintained Rust dependency (daemonize, flagged by RUSTSEC-2025-0069) from the CLI crate and cleans up leftover dead/commented references in the daemon startup code.
Changes:
- Dropped
daemonize = "0.5"fromcli’s Unix-only dependencies. - Removed a stale commented-out daemonization block from
start_daemon().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cli/Cargo.toml |
Removes the daemonize dependency from Unix-specific dependencies. |
cli/src/daemon/server.rs |
Deletes an obsolete commented-out daemonization section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Platform-specific daemon support | ||
| [target.'cfg(unix)'.dependencies] | ||
| daemonize = "0.5" | ||
| libc = "0.2" |
There was a problem hiding this comment.
Since CI and release workflows run Cargo with --locked, removing daemonize from this manifest also requires committing the regenerated Cargo.lock. The current lockfile still lists daemonize as a dependency of the aegis-orchestrator package, which will cause cargo * --locked to fail until the lockfile is updated.
| libc = "0.2" | |
| libc = "0.2" | |
| daemonize = "0.5" |
daemonizev0.5.0 is flagged as unmaintained (RUSTSEC-2025-0069) — no upstream activity since June 2023, issues disabled, maintainer unreachable.Changes
cli/Cargo.toml— Dropdaemonize = "0.5"from[target.'cfg(unix)'.dependencies]cli/src/daemon/server.rs— Remove the stale commented-out block referencingdaemonize_process()Notes
No functional replacement needed. The crate was only referenced inside a dead, commented-out block. Actual backgrounding is handled by the CLI spawning a detached child process via
std::process::Commandwithprocess_group(0)— thedaemonizecode path was already abandoned due tofork()being unsafe inside a Tokio runtime.