Move dialogs onto Reka UI primitives - #104
Draft
jwahdatehagh wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v-model:open, slots,compat,clickOutside,closable,large, fallthrough attributes, and transition-completeclosedbehaviorCompatibility
This keeps the wrapper API but intentionally changes the default surface from native
<dialog>to a Reka-managed<div role="dialog">. Consumers stylingdialog[open]ordialog::backdropshould use.dialog[data-state="open"]and.dialog-overlay. In compat mode, the overlay now precedes the article within.dialog-layer. The Changeset and component documentation call out these selector migrations.Validation
pnpm testpnpm typecheckpnpm lintpnpm format:checkpnpm buildgit diff --checkStack
This is stacked on #102, which upgrades Reka UI to 2.10.3 and adds the component interaction/a11y harness and repository quality gates. Review this PR as the single commit after #102.
Follow-up
Concurrent
useConfirm()calls still share the existing singleton contract and can supersede one another. A queue or explicit rejection policy should be designed separately rather than hidden inside this primitive migration.