From 9fbbd9f8251e14037183bbaba0f82658767a06ba Mon Sep 17 00:00:00 2001 From: Hashim Khan <64767361+Hashim1999164@users.noreply.github.com> Date: Thu, 16 Jul 2026 03:27:09 +0500 Subject: [PATCH] fix parse regex backtracking Avoid ambiguous digit matching in parse() so invalid numeric strings fail without excessive regex backtracking. --- src/index.ts | 2 +- src/parse.test.ts | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/index.ts b/src/index.ts index d50e3c7..e073ba0 100644 --- a/src/index.ts +++ b/src/index.ts @@ -75,7 +75,7 @@ export function parse(str: string): number { ); } const match = - /^(?-?\d*\.?\d+) *(?milliseconds?|msecs?|ms|seconds?|secs?|s|minutes?|mins?|m|hours?|hrs?|h|days?|d|weeks?|w|months?|mo|years?|yrs?|y)?$/i.exec( + /^(?-?(?:\d+(?:\.\d+)?|\.\d+)) *(?milliseconds?|msecs?|ms|seconds?|secs?|s|minutes?|mins?|m|hours?|hrs?|h|days?|d|weeks?|w|months?|mo|years?|yrs?|y)?$/i.exec( str, ); diff --git a/src/parse.test.ts b/src/parse.test.ts index 9182411..8789723 100644 --- a/src/parse.test.ts +++ b/src/parse.test.ts @@ -54,6 +54,10 @@ describe('parse(string)', () => { expect(Number.isNaN(parse('foo'))).toBe(true); }); + it('should return NaN for invalid max-length numeric input', () => { + expect(Number.isNaN(parse(`${'9'.repeat(99)}z`))).toBe(true); + }); + it('should be case-insensitive', () => { expect(parse('53 YeArS')).toBe(1672552800000); expect(parse('53 WeEkS')).toBe(32054400000);