Merge pull request #2827 from trycompai/chas/add-comments-to-findings

CS-367 [Feature] Ability to add comments directly to findings

Author: tofikwest

apps/api/src/audit/audit-log.constants.ts

@@ -61,6 +61,7 @@ export const COMMENT_ENTITY_TYPE_MAP: Record<string, AuditLogEntityType> = {
   [CommentEntityType.vendor]: AuditLogEntityType.vendor,
   [CommentEntityType.risk]: AuditLogEntityType.risk,
   [CommentEntityType.policy]: AuditLogEntityType.policy,
+  [CommentEntityType.finding]: AuditLogEntityType.finding,
 };
 
 // Fields that reference the member table and should be resolved to user names.

apps/api/src/comments/comment-mention-notifier.service.ts

@@ -174,6 +174,27 @@ async function buildFallbackCommentContext(params: {
     };
   }
 
+  if (entityType === CommentEntityType.finding) {
+    const finding = await db.finding.findFirst({
+      where: { id: entityId, organizationId },
+      select: { content: true },
+    });
+
+    if (!finding) {
+      return null;
+    }
+
+    const url = new URL(`${appUrl}/${organizationId}/overview/findings`);
+    url.searchParams.set('open', entityId);
+
+    const snippet = finding.content?.trim().split('\n')[0]?.slice(0, 80);
+    return {
+      entityName: snippet || 'Finding',
+      entityRoutePath: 'overview/findings',
+      commentUrl: url.toString(),
+    };
+  }
+
   // CommentEntityType.policy
   const policy = await db.policy.findFirst({
     where: { id: entityId, organizationId },

apps/api/src/comments/comments.service.ts

@@ -120,6 +120,14 @@ export class CommentsService {
         break;
       }
 
+      case CommentEntityType.finding: {
+        const finding = await db.finding.findFirst({
+          where: { id: entityId, organizationId },
+        });
+        entityExists = !!finding;
+        break;
+      }
+
       default:
         throw new BadRequestException(`Unsupported entity type: ${entityType}`);
     }

apps/app/src/app/(app)/[orgId]/overview/components/FindingDetailSheet.tsx

@@ -415,7 +415,12 @@ export function FindingDetailSheet({
                 Comments
               </Text>
               {finding ? (
-                <Comments entityId={finding.id} entityType="finding" />
+                <Comments
+                  entityId={finding.id}
+                  entityType="finding"
+                  organizationId={organizationId}
+                  readOnly={!canUpdate}
+                />
               ) : null}
             </Stack>
 

packages/db/prisma/migrations/20260512120000_add_finding_to_comment_entity_type/migration.sql

@@ -0,0 +1,2 @@
+-- AlterEnum
+ALTER TYPE "CommentEntityType" ADD VALUE 'finding';