fix(training): make the canonical/rendered video lists exhaustive both ways

`satisfies readonly CanonicalTrainingVideo[]` only proved that every
rendered video is canonical. The reverse — a canonical ID with no
rendered video — still compiled, and that is the dangerous direction:
completion requires a row for every canonical ID, so adding one without
a matching video would leave employees permanently unable to finish
training.

Key the data by the canonical union instead. `Record<GeneralTrainingVideoId,
...>` is exhaustive by construction, so both drifts now fail the build:
a missing key (TS2741) and an unknown key (TS2353). Verified by
introducing each drift and compiling.

The `Exclude<GeneralTrainingVideoId, (typeof trainingVideos)[number]['id']>`
form would not have worked here — the `readonly TrainingVideo[]`
annotation widens `id` to `string`, so the Exclude resolves to `never`
and the guard passes vacuously.

Author: tofikwest

apps/app/src/lib/data/training-videos.ts

@@ -18,48 +18,52 @@ export interface TrainingVideo {
 }
 
 /**
- * A rendered video whose ID is one the training-completion paths actually
- * accept. `@trycompai/company` owns the canonical ID list, shared with the
- * NestJS training service and the portal's complete-training route.
+ * Videos keyed by the canonical IDs that `@trycompai/company` owns, shared
+ * with the NestJS training service and the portal's complete-training route.
+ *
+ * Keying by the canonical union makes the lists exhaustive in BOTH directions:
+ * a canonical ID with no entry here fails to compile, and an entry that isn't
+ * canonical fails too. Both matter — completion requires a row for every
+ * canonical ID, so a video we never render would leave employees permanently
+ * unable to finish training, while a rendered video the API rejects would 400.
+ *
+ * The import is type-only on purpose: client components and a Trigger.dev task
+ * import this file, and `@trycompai/company` requires `@trycompai/db` at
+ * runtime.
  */
-type CanonicalTrainingVideo = Omit<TrainingVideo, 'id'> & {
-  id: GeneralTrainingVideoId;
-};
-
-export const trainingVideos: readonly TrainingVideo[] = [
-  {
-    id: 'sat-1',
+const trainingVideosById: Record<GeneralTrainingVideoId, Omit<TrainingVideo, 'id'>> = {
+  'sat-1': {
     title: 'Security Awareness Training - Part 1',
     description: 'Security Awareness Training - Part 1',
     youtubeId: 'N-sBS3uCWB4',
     url: 'https://www.youtube.com/watch?v=N-sBS3uCWB4',
   },
-  {
-    id: 'sat-2',
+  'sat-2': {
     title: 'Security Awareness Training - Part 2',
     description: 'Security Awareness Training - Part 2',
     youtubeId: 'JwQNwhDyXig',
     url: 'https://www.youtube.com/watch?v=JwQNwhDyXig',
   },
-  {
-    id: 'sat-3',
+  'sat-3': {
     title: 'Security Awareness Training - Part 3',
     description: 'Security Awareness Training - Part 3',
     youtubeId: 'fzMNw_-KEGE',
     url: 'https://www.youtube.com/watch?v=fzMNw_-KEGE',
   },
-  {
-    id: 'sat-4',
+  'sat-4': {
     title: 'Security Awareness Training - Part 4',
     description: 'Security Awareness Training - Part 4',
     youtubeId: 'WbpqjH9kI2Y',
     url: 'https://www.youtube.com/watch?v=WbpqjH9kI2Y',
   },
-  {
-    id: 'sat-5',
+  'sat-5': {
     title: 'Security Awareness Training - Part 5',
     description: 'Security Awareness Training - Part 5',
     youtubeId: 'Clvfkm6azDs',
     url: 'https://www.youtube.com/watch?v=Clvfkm6azDs',
   },
-] as const satisfies readonly CanonicalTrainingVideo[];
+};
+
+export const trainingVideos: readonly TrainingVideo[] = Object.entries(trainingVideosById).map(
+  ([id, video]) => ({ id, ...video }),
+);

apps/portal/src/lib/data/training-videos.ts

@@ -18,48 +18,52 @@ export interface TrainingVideo {
 }
 
 /**
- * A rendered video whose ID is one the training-completion paths actually
- * accept. `@trycompai/company` owns the canonical ID list, shared with the
- * NestJS training service and the portal's complete-training route.
+ * Videos keyed by the canonical IDs that `@trycompai/company` owns, shared
+ * with the NestJS training service and the portal's complete-training route.
+ *
+ * Keying by the canonical union makes the lists exhaustive in BOTH directions:
+ * a canonical ID with no entry here fails to compile, and an entry that isn't
+ * canonical fails too. Both matter — completion requires a row for every
+ * canonical ID, so a video we never render would leave employees permanently
+ * unable to finish training, while a rendered video the API rejects would 400.
+ *
+ * The import is type-only on purpose: client components and a Trigger.dev task
+ * import this file, and `@trycompai/company` requires `@trycompai/db` at
+ * runtime.
  */
-type CanonicalTrainingVideo = Omit<TrainingVideo, 'id'> & {
-  id: GeneralTrainingVideoId;
-};
-
-export const trainingVideos: readonly TrainingVideo[] = [
-  {
-    id: 'sat-1',
+const trainingVideosById: Record<GeneralTrainingVideoId, Omit<TrainingVideo, 'id'>> = {
+  'sat-1': {
     title: 'Security Awareness Training - Part 1',
     description: 'Security Awareness Training - Part 1',
     youtubeId: 'N-sBS3uCWB4',
     url: 'https://www.youtube.com/watch?v=N-sBS3uCWB4',
   },
-  {
-    id: 'sat-2',
+  'sat-2': {
     title: 'Security Awareness Training - Part 2',
     description: 'Security Awareness Training - Part 2',
     youtubeId: 'JwQNwhDyXig',
     url: 'https://www.youtube.com/watch?v=JwQNwhDyXig',
   },
-  {
-    id: 'sat-3',
+  'sat-3': {
     title: 'Security Awareness Training - Part 3',
     description: 'Security Awareness Training - Part 3',
     youtubeId: 'fzMNw_-KEGE',
     url: 'https://www.youtube.com/watch?v=fzMNw_-KEGE',
   },
-  {
-    id: 'sat-4',
+  'sat-4': {
     title: 'Security Awareness Training - Part 4',
     description: 'Security Awareness Training - Part 4',
     youtubeId: 'WbpqjH9kI2Y',
     url: 'https://www.youtube.com/watch?v=WbpqjH9kI2Y',
   },
-  {
-    id: 'sat-5',
+  'sat-5': {
     title: 'Security Awareness Training - Part 5',
     description: 'Security Awareness Training - Part 5',
     youtubeId: 'Clvfkm6azDs',
     url: 'https://www.youtube.com/watch?v=Clvfkm6azDs',
   },
-] as const satisfies readonly CanonicalTrainingVideo[];
+};
+
+export const trainingVideos: readonly TrainingVideo[] = Object.entries(trainingVideosById).map(
+  ([id, video]) => ({ id, ...video }),
+);