Skip to content

Commit 5a8234c

Browse files
Add skill version picker to TrueFoundry UI
1 parent efcbd74 commit 5a8234c

13 files changed

Lines changed: 675 additions & 55 deletions

File tree

‎.changeset/skill-version-picker.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@truefoundry/trueforge-ui': patch
3+
---
4+
5+
Show TrueFoundry skill repositories and versions in skill pickers, load version choices lazily, preserve the chosen version FQN when attaching skills, keep picker ordering stable while open, and add registry-only preload controls to selected skill pills.

‎packages/trueforge-ui/src/atoms/draft/AgentConfigPanel.tsx‎

Lines changed: 118 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import { useState, type ReactNode } from 'react';
44

55
import { Icon } from '../../icons/Icon.js';
6-
import type { AgentSpec, ModelSelection } from '../../server/types.js';
6+
import type { AgentSkill, AgentSpec, ModelSelection } from '../../server/types.js';
77
import { useSlot } from '../../theme/SlotsProvider.js';
88
import { auiButtonClass } from '../lib/buttonClasses.js';
99
import { cn } from '../lib/cn.js';
@@ -21,6 +21,7 @@ import {
2121
import { displayModelLabel, ProviderMark } from './DraftModelCatalogPanel.js';
2222
import { modelParamSummary } from './modelParamsSummary.js';
2323
import { runtimeConfigSummary, runtimeConfigValueClassName } from './runtimeConfigSummary.js';
24+
import { skillFamilyId, skillVersion } from './SkillVersionSelector.js';
2425

2526
const DEFAULT_INSTRUCTIONS =
2627
'Enter detailed instructions for your agent. E.g. You are a helpful assistant that helps users plan trips. Always ask clarifying questions before making suggestions...';
@@ -31,6 +32,7 @@ export type AgentConfigPanelProps = {
3132
models: ModelSelection[];
3233
modelsLoading: boolean;
3334
modelsError: string | null;
35+
skills?: AgentSkill[];
3436
skillsAvailable: boolean;
3537
instructions: string;
3638
onOpenEditor: (editor: AgentConfigEditor) => void;
@@ -122,6 +124,84 @@ function McpServerChip({
122124
);
123125
}
124126

127+
function SkillChip({
128+
item,
129+
preloadAvailable,
130+
onRemove,
131+
onTogglePreload,
132+
}: {
133+
item: EditableMount;
134+
preloadAvailable: boolean;
135+
onRemove?: () => void;
136+
onTogglePreload?: () => void;
137+
}) {
138+
const preload = preloadFromMount(item.value);
139+
140+
return (
141+
<span className="flex items-center overflow-hidden rounded-md border border-border text-xs">
142+
{preloadAvailable && onTogglePreload ? (
143+
<Tooltip
144+
side="bottom"
145+
dismissOnClick={false}
146+
triggerClassName="self-stretch"
147+
className="w-64 whitespace-normal p-3 text-left shadow-lg"
148+
content={
149+
<span className="flex flex-col gap-1.5">
150+
<span className="flex items-center justify-between gap-3">
151+
<span className="font-semibold">Preload skill</span>
152+
<span className="text-primary-button-bg text-[0.625rem] font-semibold tracking-wide uppercase">
153+
{preload ? 'ON' : 'OFF'}
154+
</span>
155+
</span>
156+
<span className="text-text-secondary text-xs leading-snug">
157+
Inline SKILL.md in the agent context upfront. When off, the agent loads the skill dynamically.
158+
</span>
159+
</span>
160+
}
161+
>
162+
<button
163+
type="button"
164+
aria-pressed={preload}
165+
aria-label={`Preload skill ${item.name}`}
166+
className={cn(
167+
'flex h-full items-center justify-center border-r border-border px-1.5 transition-colors',
168+
preload
169+
? 'bg-primary-button-bg text-primary-button-text'
170+
: 'text-text-secondary hover:bg-ghost-button-hover',
171+
)}
172+
onClick={event => {
173+
event.stopPropagation();
174+
onTogglePreload();
175+
}}
176+
>
177+
<Icon name="book-open" className="size-3.5" />
178+
</button>
179+
</Tooltip>
180+
) : null}
181+
<span className="py-1 pl-2">{item.name}</span>
182+
{onRemove ? (
183+
<button
184+
type="button"
185+
aria-label={`Remove ${item.name}`}
186+
className={auiButtonClass({
187+
variant: 'ghost',
188+
size: 'icon',
189+
className: 'mx-1 size-5',
190+
})}
191+
onClick={event => {
192+
event.stopPropagation();
193+
onRemove();
194+
}}
195+
>
196+
<Icon name="xmark" className="size-3" />
197+
</button>
198+
) : (
199+
<span className="pr-2" />
200+
)}
201+
</span>
202+
);
203+
}
204+
125205
export function AgentConfigSection({
126206
title,
127207
description,
@@ -200,6 +280,7 @@ export function AgentConfigPanel({
200280
models,
201281
modelsLoading,
202282
modelsError,
283+
skills: catalogSkills = [],
203284
skillsAvailable,
204285
instructions,
205286
onOpenEditor,
@@ -213,7 +294,7 @@ export function AgentConfigPanel({
213294
const [modelSettingsMenuOpen, setModelSettingsMenuOpen] = useState(false);
214295
const [modelQuery, setModelQuery] = useState('');
215296
const mcp = editableMountsFromSpec(spec.mcpServers);
216-
const skills = editableMountsFromSpec(spec.skills);
297+
const skillMounts = editableMountsFromSpec(spec.skills);
217298
const modelParams = modelParamSummary(spec.model.params);
218299
const runtimeConfig = runtimeConfigSummary(spec.config);
219300
const instructionPreview = instructions.trim();
@@ -427,13 +508,42 @@ export function AgentConfigPanel({
427508
<Section title="Skills" actionIcon="plus" actionLabel="Add skill" onEdit={() => onOpenEditor('skills')}>
428509
{!skillsAvailable ? (
429510
<p className="text-text-secondary text-xs">Skills require an available sandbox.</p>
430-
) : skills.length ? (
511+
) : skillMounts.length ? (
431512
<div className="flex flex-wrap gap-1.5">
432-
{skills.map(item => (
433-
<span key={item.id} className="rounded-md border border-border px-2 py-1 text-xs">
434-
{item.name}
435-
</span>
436-
))}
513+
{skillMounts.map(item => {
514+
const preloadAvailable = catalogSkills.some(
515+
skill => skillVersion(skill) !== undefined && skillFamilyId(skill.id) === skillFamilyId(item.id),
516+
);
517+
return (
518+
<SkillChip
519+
key={item.id}
520+
item={item}
521+
preloadAvailable={preloadAvailable}
522+
onRemove={
523+
onChange
524+
? () =>
525+
onChange({
526+
...spec,
527+
skills: skillMounts.filter(mount => mount.id !== item.id).map(mount => mount.value),
528+
})
529+
: undefined
530+
}
531+
onTogglePreload={
532+
preloadAvailable && onChange
533+
? () =>
534+
onChange({
535+
...spec,
536+
skills: skillMounts.map(mount =>
537+
mount.id === item.id
538+
? withPreload(mount.value, !preloadFromMount(mount.value))
539+
: mount.value,
540+
),
541+
})
542+
: undefined
543+
}
544+
/>
545+
);
546+
})}
437547
</div>
438548
) : (
439549
<p className="text-text-secondary text-xs">No skills selected.</p>

‎packages/trueforge-ui/src/atoms/draft/AgentSkillsEditorContent.tsx‎

Lines changed: 48 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,19 @@
11
'use client';
22

3+
import { useState } from 'react';
4+
35
import { Icon } from '../../icons/Icon.js';
46
import type { AgentSkill, AgentSpec } from '../../server/types.js';
57
import { useSlot } from '../../theme/SlotsProvider.js';
68
import { auiInputClass } from '../lib/inputClasses.js';
79
import { editableMountsFromSpec } from './agentConfigMounts.js';
10+
import {
11+
SkillVersionSelector,
12+
skillFamilyId,
13+
skillRepoName,
14+
skillVersion,
15+
type SkillVersionOption,
16+
} from './SkillVersionSelector.js';
817

918
export type AgentSkillsEditorContentProps = {
1019
spec: AgentSpec;
@@ -24,13 +33,17 @@ export function AgentSkillsEditorContent({
2433
onChange,
2534
}: AgentSkillsEditorContentProps) {
2635
const CatalogRow = useSlot('CatalogRow');
36+
const [selectedVersions, setSelectedVersions] = useState<Record<string, SkillVersionOption>>({});
2737
const skillMounts = editableMountsFromSpec(spec.skills);
38+
const [initialSelectedFamilies] = useState(() => new Set(skillMounts.map(item => skillFamilyId(item.id))));
2839
const normalizedQuery = query.trim().toLowerCase();
2940
const filteredSkills = skills
30-
.filter(item => `${item.name} ${item.description ?? ''}`.toLowerCase().includes(normalizedQuery))
41+
.filter(item =>
42+
`${item.name} ${skillRepoName(item) ?? ''} ${item.description ?? ''}`.toLowerCase().includes(normalizedQuery),
43+
)
3144
.sort((left, right) => {
32-
const leftSelected = skillMounts.some(item => item.id === left.id || item.name === left.name);
33-
const rightSelected = skillMounts.some(item => item.id === right.id || item.name === right.name);
45+
const leftSelected = initialSelectedFamilies.has(skillFamilyId(left.id));
46+
const rightSelected = initialSelectedFamilies.has(skillFamilyId(right.id));
3447
return Number(rightSelected) - Number(leftSelected);
3548
});
3649

@@ -47,20 +60,50 @@ export function AgentSkillsEditorContent({
4760
</label>
4861
<div className="min-h-0 flex-1 overflow-y-auto p-2">
4962
{filteredSkills.map(skill => {
50-
const mount = skillMounts.find(item => item.id === skill.id || item.name === skill.name);
63+
const mount = skillMounts.find(item => skillFamilyId(item.id) === skillFamilyId(skill.id));
64+
const selectedVersion = selectedVersions[skill.id];
65+
const repoName = skillRepoName(skill);
5166
return (
5267
<CatalogRow
5368
key={skill.id}
5469
title={skill.name}
5570
description={skill.description}
71+
badge={
72+
repoName === undefined ? undefined : (
73+
<span className="bg-primary-button-bg/10 text-primary-button-bg shrink-0 rounded-full px-1.5 py-0.5 text-[0.625rem]">
74+
{repoName}
75+
</span>
76+
)
77+
}
5678
checked={mount !== undefined}
5779
disabled={skillsDisabled && mount === undefined}
80+
action={
81+
skillVersion(skill) === undefined ? undefined : (
82+
<SkillVersionSelector
83+
skill={skill}
84+
selectedId={selectedVersion?.id ?? mount?.id}
85+
onChange={version => {
86+
setSelectedVersions(previous => ({ ...previous, [skill.id]: version }));
87+
if (mount === undefined) return;
88+
onChange({
89+
...spec,
90+
skills: skillMounts.map(item =>
91+
item === mount ? { ...item.value, id: version.id, name: version.name } : item.value,
92+
),
93+
});
94+
}}
95+
/>
96+
)
97+
}
5898
onToggle={() => {
5999
const adding = mount === undefined;
60100
onChange({
61101
...spec,
62102
skills: adding
63-
? [...(spec.skills ?? []), { id: skill.id, name: skill.name }]
103+
? [
104+
...(spec.skills ?? []),
105+
{ id: selectedVersion?.id ?? skill.id, name: selectedVersion?.name ?? skill.name },
106+
]
64107
: skillMounts.filter(item => item !== mount).map(item => item.value),
65108
...(adding
66109
? {

0 commit comments

Comments
 (0)