11import { AgentSpecSchema } from '@truefoundry/trueforge-core/agent-session' ;
22
33import type { AgentRecord , IAgentStore } from '../../../src/db/agentStore' ;
4+ import { AgentNameConflictError } from '../../../src/db/agentStore' ;
45import { TrueFoundryAgentStore } from '../../../src/truefoundry/TrueFoundryAgentStore' ;
56import {
67 TrueFoundryServiceFoundryServerClient ,
@@ -98,9 +99,10 @@ describe('TrueFoundryAgentStore', () => {
9899 } ) ;
99100 return { remoteAgentId : 'sf-1' } ;
100101 } ) ;
102+ const getAgent = jest . fn ( async ( ) => undefined ) ;
101103 const createAgent = jest . fn ( async ( ) => created ) ;
102104 const store = new TrueFoundryAgentStore ( {
103- inner : mockInner ( { createAgent } ) ,
105+ inner : mockInner ( { getAgent , createAgent } ) ,
104106 client : mockClient ( { putRemoteAgent } ) ,
105107 accessToken : TOKEN ,
106108 } ) ;
@@ -112,6 +114,7 @@ describe('TrueFoundryAgentStore', () => {
112114 manifest : manifest ( { mcp_servers : [ { name : 'slack' } ] } ) ,
113115 } ) ,
114116 ) . resolves . toBe ( created ) ;
117+ expect ( getAgent ) . toHaveBeenCalledWith ( { tenant_id : TENANT , name : 'research' } , undefined ) ;
115118 expect ( createAgent ) . toHaveBeenCalledWith (
116119 expect . objectContaining ( {
117120 tenant_id : TENANT ,
@@ -122,6 +125,25 @@ describe('TrueFoundryAgentStore', () => {
122125 ) ;
123126 } ) ;
124127
128+ it ( 'createAgent rejects a duplicate local name before calling ServiceFoundry' , async ( ) => {
129+ const getAgent = jest . fn ( async ( ) => record ( { external_id : 'sf-existing' } ) ) ;
130+ const createAgent = jest . fn ( ) ;
131+ const putRemoteAgent = jest . fn ( ) ;
132+ const deleteRemoteAgent = jest . fn ( ) ;
133+ const store = new TrueFoundryAgentStore ( {
134+ inner : mockInner ( { getAgent, createAgent } ) ,
135+ client : mockClient ( { putRemoteAgent, deleteRemoteAgent } ) ,
136+ accessToken : TOKEN ,
137+ } ) ;
138+
139+ await expect (
140+ store . createAgent ( { tenant_id : TENANT , name : 'research' , manifest : manifest ( ) } ) ,
141+ ) . rejects . toMatchObject ( { name : 'AgentNameConflictError' } ) ;
142+ expect ( putRemoteAgent ) . not . toHaveBeenCalled ( ) ;
143+ expect ( createAgent ) . not . toHaveBeenCalled ( ) ;
144+ expect ( deleteRemoteAgent ) . not . toHaveBeenCalled ( ) ;
145+ } ) ;
146+
125147 it ( 'createAgent uses agent name as description when instructions are omitted' , async ( ) => {
126148 const putRemoteAgent = jest . fn ( async ( input : PutRemoteAgentInput ) => {
127149 expect ( input . description ) . toBe ( 'research' ) ;
@@ -159,6 +181,23 @@ describe('TrueFoundryAgentStore', () => {
159181 expect ( deleteRemoteAgent ) . toHaveBeenCalledWith ( { accessToken : TOKEN , remoteAgentId : 'sf-1' } ) ;
160182 } ) ;
161183
184+ it ( 'createAgent does not delete remote on local name conflict after put' , async ( ) => {
185+ const deleteRemoteAgent = jest . fn ( ) ;
186+ const createAgent = jest . fn ( async ( ) => {
187+ throw new AgentNameConflictError ( { tenant_id : TENANT , name : 'research' } ) ;
188+ } ) ;
189+ const store = new TrueFoundryAgentStore ( {
190+ inner : mockInner ( { createAgent } ) ,
191+ client : mockClient ( { deleteRemoteAgent } ) ,
192+ accessToken : TOKEN ,
193+ } ) ;
194+
195+ await expect (
196+ store . createAgent ( { tenant_id : TENANT , name : 'research' , manifest : manifest ( ) } ) ,
197+ ) . rejects . toBeInstanceOf ( AgentNameConflictError ) ;
198+ expect ( deleteRemoteAgent ) . not . toHaveBeenCalled ( ) ;
199+ } ) ;
200+
162201 it ( 'createAgent still throws when SF rollback fails' , async ( ) => {
163202 const deleteRemoteAgent = jest . fn ( async ( ) => {
164203 throw new Error ( 'cleanup failed' ) ;
0 commit comments