util: make WakeList::wake_all use FIFO ordering#6521
Merged
Conversation
Darksonn
reviewed
Apr 28, 2024
Darksonn
reviewed
Apr 29, 2024
Member
Darksonn
left a comment
There was a problem hiding this comment.
Looks correct, but I have some comments on the safety comments.
Darksonn
reviewed
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#6517 (comment) noted that the current implementation of
WakeList::wake_allis LIFO, while the original pre-WakeListimplementations were FIFO. The very first implementation ofWakeListwas FIFO, but it also was also unsound in the case theWakerpanicked, so it was changed to work as it is currently implemented.Solution
This changes
WakeListto be FIFO by processingWakers in order and using aDropGuardto handle panics.