From e24d2bebeae42da535a1e8fe29a4c7153ea15937 Mon Sep 17 00:00:00 2001 From: kepakiano Date: Sat, 6 Jun 2026 20:38:53 +0200 Subject: [PATCH 1/2] [core] read forced_share_percent from options --- lib/engine/corporation.rb | 1 + lib/engine/game/g_1835/entities.rb | 2 ++ lib/engine/game/g_1835/game.rb | 2 -- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/engine/corporation.rb b/lib/engine/corporation.rb index 8cf0da54c8..dc60f026ac 100644 --- a/lib/engine/corporation.rb +++ b/lib/engine/corporation.rb @@ -78,6 +78,7 @@ def initialize(sym:, name:, **opts) @reservation_color = opts[:reservation_color] @price_percent = opts[:price_percent] || @second_share&.percent || (@presidents_share.percent / 2) @price_multiplier = (@second_share&.percent || (@presidents_share.percent / 2)) / @price_percent + @forced_share_percent = opts[:@forced_share_percent] @treasury_as_holding = opts[:treasury_as_holding] || false @corporation_can_ipo = opts[:corporation_can_ipo] diff --git a/lib/engine/game/g_1835/entities.rb b/lib/engine/game/g_1835/entities.rb index 418ed614d5..4691f848c9 100644 --- a/lib/engine/game/g_1835/entities.rb +++ b/lib/engine/game/g_1835/entities.rb @@ -298,6 +298,7 @@ module Entities max_ownership_percent: 100, shares: [20, 20, 20, 10, 10, 10, 10], price_percent: 20, + forced_share_percent: 10, fraction_shares: false, coordinates: 'C13', color: :violet, @@ -314,6 +315,7 @@ module Entities max_ownership_percent: 100, shares: [20, 20, 20, 10, 10, 10, 10], price_percent: 20, + forced_share_percent: 10, fraction_shares: false, coordinates: 'D6', color: '#6e6966', diff --git a/lib/engine/game/g_1835/game.rb b/lib/engine/game/g_1835/game.rb index dd805653e6..6573cd4ac5 100644 --- a/lib/engine/game/g_1835/game.rb +++ b/lib/engine/game/g_1835/game.rb @@ -187,8 +187,6 @@ def setup corporation_by_id('BY').ipoed = true corporation_by_id('SX').ipoed = true - corporation_by_id('MS').forced_share_percent = 10 - corporation_by_id('OL').forced_share_percent = 10 @corporation_blocks = CORPORATION_BLOCKS.map { |block| block.map { |c| corporation_by_id(c) } } end From a1776ff2f930c6f0cdc5a94a4beee4da63886a0d Mon Sep 17 00:00:00 2001 From: kepakiano Date: Sun, 14 Jun 2026 22:21:21 +0200 Subject: [PATCH 2/2] [core] fix reading forced_share_percnt from options --- lib/engine/corporation.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/engine/corporation.rb b/lib/engine/corporation.rb index dc60f026ac..9b666bcc0f 100644 --- a/lib/engine/corporation.rb +++ b/lib/engine/corporation.rb @@ -78,7 +78,7 @@ def initialize(sym:, name:, **opts) @reservation_color = opts[:reservation_color] @price_percent = opts[:price_percent] || @second_share&.percent || (@presidents_share.percent / 2) @price_multiplier = (@second_share&.percent || (@presidents_share.percent / 2)) / @price_percent - @forced_share_percent = opts[:@forced_share_percent] + @forced_share_percent = opts[:forced_share_percent] @treasury_as_holding = opts[:treasury_as_holding] || false @corporation_can_ipo = opts[:corporation_can_ipo]