From 1a3ffcfc7b940ea96f00ee95de5cccd97357377b Mon Sep 17 00:00:00 2001 From: Mathieu St-Vincent Date: Wed, 25 Feb 2026 11:41:44 -0500 Subject: [PATCH] fix: openai client: returning standard error instead of new declaration on context cancelation --- llms/openai/internal/openaiclient/openaiclient.go | 2 +- llms/openai/internal/openaiclient/openaiclient_test.go | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/llms/openai/internal/openaiclient/openaiclient.go b/llms/openai/internal/openaiclient/openaiclient.go index e0a09d1fb..a6dd25f18 100644 --- a/llms/openai/internal/openaiclient/openaiclient.go +++ b/llms/openai/internal/openaiclient/openaiclient.go @@ -225,7 +225,7 @@ func sanitizeHTTPError(err error) error { // Check for context cancellation if errors.Is(err, context.Canceled) { - return errors.New("request cancelled") + return context.Canceled } // Check for network timeout errors diff --git a/llms/openai/internal/openaiclient/openaiclient_test.go b/llms/openai/internal/openaiclient/openaiclient_test.go index a9d0f4140..be7513da5 100644 --- a/llms/openai/internal/openaiclient/openaiclient_test.go +++ b/llms/openai/internal/openaiclient/openaiclient_test.go @@ -374,8 +374,7 @@ func TestSanitizeHTTPError(t *testing.T) { t.Run("context cancelled", func(t *testing.T) { err := context.Canceled sanitized := sanitizeHTTPError(err) - assert.Error(t, sanitized) - assert.Equal(t, "request cancelled", sanitized.Error()) + assert.ErrorIs(t, sanitized, context.Canceled) }) t.Run("network timeout", func(t *testing.T) {