Skip to content

Commit 5d17278

Browse files
committed
fix: failed to create nsis
1 parent 107b202 commit 5d17278

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎.github/workflows/release-windows.yaml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,11 @@ jobs:
100100
- name: Build Windows NSIS installer
101101
shell: bash
102102
run: |
103+
export PATH="/c/Program Files (x86)/NSIS:$PATH"
104+
which makensis && echo "makensis found" || echo "makensis NOT found"
103105
CGO_ENABLED=1 wails build -clean -platform ${{ matrix.platform }} \
104106
-nsis -webview2 embed \
105-
-ldflags "-X main.version=v${{ steps.normalise_version.outputs.version }}"
107+
-ldflags "-X main.version=v${{ steps.normalise_version.outputs.version }} -X main.gaMeasurementID=${{ secrets.GA_MEASUREMENT_ID }} -X main.gaSecretKey=${{ secrets.WINDOWS_GA_SECRET }}"
106108
107109
- name: Sign the installer
108110
uses: dlemstra/code-sign-action@v1
@@ -113,7 +115,7 @@ jobs:
113115

114116
- name: Rename installer
115117
working-directory: ./build/bin
116-
run: Rename-Item -Path "Tiny RDM.exe" -NewName "TinyRDM_Setup_${{ steps.normalise_version.outputs.version }}_${{ steps.normalise_platform.outputs.tag }}.exe"
118+
run: Rename-Item -Path "tinyrdm-${{ steps.normalise_platform_name.outputs.pname }}-installer.exe" -NewName "TinyRDM_Setup_${{ steps.normalise_version.outputs.version }}_${{ steps.normalise_platform.outputs.tag }}.exe"
117119

118120
- name: Upload release asset (Installer)
119121
uses: softprops/action-gh-release@v1

0 commit comments

Comments
 (0)