Repository navigation
Conversation
🛡️ Tently reviewFound 1 finding — 🟠 1 high. 1. 🟠 getEnvFilesForMode now returns absolute paths (joined with envDir), but handleHMRUpdate still compares against fileName, which is path.basename(file). The includes() check never matches, so isEnv is always false. Changes to .env files no longer restart the dev server. The call site was updated to paRegression · 🟠 High · Confidence 93% · getEnvFilesForMode now returns absolute paths (joined with envDir), but handleHMRUpdate still compares against fileName, which is path.basename(file). The includes() check never matches, so isEnv is always false. Changes to .env files no longer restart the dev server. The call site was updated to pass envDir, but the comparison still uses the basename. It should compare against Evidence
Impacted symbols: Posted by Tently · reply with |
Author
|
@tently-team/dev review this |
1 similar comment
Author
|
@tently-team/dev review this |
Member
|
@tently review this |
1 similar comment
Author
|
@tently review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: vitejs#15347
I wanted to create a test that would assert that page reload don't happen on editing (
.env) in theenv-nestedplayground, but asserting empty serverLogs is not really strong. Ideally we should be able to opt-in into debug logs on a test( suite) bases, but this would require re-loading Vite sources before each test and feels too much for such a small test