From 047b690cfee7bd91adcfd6bcde39e19151f50ea2 Mon Sep 17 00:00:00 2001 From: Tegan Churchill Date: Mon, 4 May 2026 14:47:24 -0700 Subject: [PATCH 1/4] More trivial migrations --- .../components/batch-operations/header.svelte | 6 +- src/lib/components/data-encoder-status.svelte | 10 +-- .../import/event-history-file-import.svelte | 9 ++- .../lines-and-dots/event-sort-filter.svelte | 26 +++++--- .../lines-and-dots/svg/timeline-graph.svelte | 65 ++++++++++++------- .../close-filter-button.svelte | 2 + .../filter-list.svelte | 16 +++-- .../status-filter.svelte | 16 +++-- .../filter-bar.svelte | 2 + .../index.svelte | 22 +++++-- .../orderable-list.svelte | 28 ++++---- .../dropdown-filter/conditional.svelte | 10 ++- .../relationships/workflow-family-tree.svelte | 14 ++-- .../workflow/scheduler-table.svelte | 2 + .../workflow-relationships-old.svelte | 32 ++++----- src/lib/holocene/day-of-month-picker.svelte | 10 ++- src/lib/holocene/day-of-week-picker.svelte | 10 ++- src/lib/holocene/month-picker.svelte | 10 ++- src/lib/holocene/select/multi-select.svelte | 57 +++++++++++----- src/lib/holocene/toaster.svelte | 12 ++-- src/lib/holocene/user-menu.svelte | 10 ++- src/lib/pages/batch-operation.svelte | 10 ++- src/lib/pages/workflow-metadata.svelte | 2 +- src/routes/+error.svelte | 32 +++++---- 24 files changed, 267 insertions(+), 146 deletions(-) diff --git a/src/lib/components/batch-operations/header.svelte b/src/lib/components/batch-operations/header.svelte index 2b74341774..56d12edd61 100644 --- a/src/lib/components/batch-operations/header.svelte +++ b/src/lib/components/batch-operations/header.svelte @@ -8,7 +8,11 @@ import { autoRefresh } from '$lib/stores/batch-operations'; import type { BatchOperation, BatchOperationState } from '$lib/types/batch'; - export let operation: BatchOperation; + interface Props { + operation: BatchOperation; + } + + let { operation }: Props = $props(); const dispatch = createEventDispatcher<{ toggleAutoRefresh: { checked: boolean }; diff --git a/src/lib/components/data-encoder-status.svelte b/src/lib/components/data-encoder-status.svelte index 0c9140cfe6..a73f195292 100644 --- a/src/lib/components/data-encoder-status.svelte +++ b/src/lib/components/data-encoder-status.svelte @@ -13,13 +13,9 @@ } }; - let variant: 'primary' | 'ghost' = 'ghost'; - - const updateVariant = (open: boolean) => { - variant = open ? 'primary' : 'ghost'; - }; - - $: updateVariant($viewDataEncoderSettings); + const variant = $derived<'primary' | 'ghost'>( + $viewDataEncoderSettings ? 'primary' : 'ghost', + );
diff --git a/src/lib/components/import/event-history-file-import.svelte b/src/lib/components/import/event-history-file-import.svelte index f2cf708e60..ca015a786b 100644 --- a/src/lib/components/import/event-history-file-import.svelte +++ b/src/lib/components/import/event-history-file-import.svelte @@ -1,3 +1,5 @@ + + diff --git a/src/lib/components/lines-and-dots/svg/timeline-graph.svelte b/src/lib/components/lines-and-dots/svg/timeline-graph.svelte index 0048821884..e3254b44a4 100644 --- a/src/lib/components/lines-and-dots/svg/timeline-graph.svelte +++ b/src/lib/components/lines-and-dots/svg/timeline-graph.svelte @@ -17,38 +17,57 @@ import TimelineGraphRow from './timeline-graph-row.svelte'; import WorkflowRow from './workflow-row.svelte'; - export let x = 0; - export let y = 0; - export let workflow: WorkflowExecution; - export let groups: EventGroups; - export let viewportHeight: number | undefined; - export let readOnly = false; - export let error: boolean = false; + interface Props { + x?: number; + y?: number; + workflow: WorkflowExecution; + groups: EventGroups; + viewportHeight: number | undefined; + readOnly?: boolean; + error?: boolean; + } + + let { + x = 0, + y = 0, + workflow, + groups, + viewportHeight, + readOnly = false, + error = false, + }: Props = $props(); const { height, gutter, radius } = TimelineConfig; - let canvasWidth = 0; - let scrollY = 0; + let canvasWidth = $state(0); + let scrollY = $state(0); - $: expandedGroupHeight = readOnly ? 0 : $activeGroupHeight; - $: filteredGroups = getFailedOrPendingGroups(groups, $eventStatusFilter); - $: firstStartTime = + const expandedGroupHeight = $derived(readOnly ? 0 : $activeGroupHeight); + const filteredGroups = $derived( + getFailedOrPendingGroups(groups, $eventStatusFilter), + ); + const firstStartTime = $derived( $fullEventHistory[0]?.eventTime < workflow.executionTime ? $fullEventHistory[0]?.eventTime - : workflow.executionTime; - $: startTime = - (!isWorkflowDelayed(workflow) && firstStartTime) || workflow.startTime; - $: timelineHeight = - Math.max(height * (filteredGroups.length + 2), 120) + expandedGroupHeight; - $: canvasHeight = timelineHeight + 120; + : workflow.executionTime, + ); + const startTime = $derived( + (!isWorkflowDelayed(workflow) && firstStartTime) || workflow.startTime, + ); + const timelineHeight = $derived( + Math.max(height * (filteredGroups.length + 2), 120) + expandedGroupHeight, + ); + const canvasHeight = $derived(timelineHeight + 120); - const handleScroll = (e) => { - scrollY = e?.target?.scrollTop; + const handleScroll = (e: Event) => { + scrollY = (e?.target as HTMLElement)?.scrollTop; }; - $: groupIndexMap = new Map(filteredGroups.map((g, i) => [g.id, i])); + const groupIndexMap = $derived( + new Map(filteredGroups.map((g, i) => [g.id, i])), + ); - $: activeGroupsHeightAboveGroup = (groupIndex: number) => { + const activeGroupsHeightAboveGroup = (groupIndex: number) => { const hasActiveAbove = $activeGroups?.some((id) => { const activeIndex = groupIndexMap.get(id); return activeIndex !== undefined && activeIndex < groupIndex; @@ -62,7 +81,7 @@ class="relative h-auto overflow-auto border border-t-0 border-subtle bg-primary" bind:clientWidth={canvasWidth} style={viewportHeight ? `max-height: ${viewportHeight}px;` : ''} - on:scroll={handleScroll} + onscroll={handleScroll} > + @@ -65,7 +71,7 @@ Available Columns (not in view) - {#each $availableColumns as { label }} + {#each $availableColumns as { label } (label)} addColumn(label, namespace, table)} @@ -86,7 +92,7 @@ {translate('events.custom-search-attributes')} (not in view) - {#each $availableCustomColumns as { label }} + {#each $availableCustomColumns as { label } (label)} addColumn(label, namespace, table)} diff --git a/src/lib/components/workflow/dropdown-filter/conditional.svelte b/src/lib/components/workflow/dropdown-filter/conditional.svelte index baffba2ed8..1e2f31ecc3 100644 --- a/src/lib/components/workflow/dropdown-filter/conditional.svelte +++ b/src/lib/components/workflow/dropdown-filter/conditional.svelte @@ -1,14 +1,18 @@
-