Improve sharing failure diagnostics

Log handled publishing and clipboard failures with their full exception chains so recoverable sharing issues can be diagnosed without interrupting users.\n\nKeep the share dialog out of the taskbar and cover operation-failure logging, including nested transport exceptions.

Author: mzagozda

src/NoteManager.Core/Services/ApplicationActivityLog.cs

@@ -3,7 +3,7 @@
 namespace NoteManager.App.Services;
 
 /// <summary>
-/// Writes a small local audit trail for application startup, folder use, and crashes.
+/// Writes a small local audit trail for application startup, folder use, recoverable failures, and crashes.
 /// </summary>
 public sealed class ApplicationActivityLog
 {
@@ -33,6 +33,18 @@ public bool TryWriteFolderRestoredFromPreviousSession(string folder)
             "Repository folder opened from previous session",
             folder);
 
+    /// <summary>
+    /// Records a handled operation failure with its complete exception chain so support can diagnose it.
+    /// </summary>
+    public bool TryWriteOperationFailure(string operation, Exception exception)
+    {
+        ArgumentException.ThrowIfNullOrWhiteSpace(operation);
+        ArgumentNullException.ThrowIfNull(exception);
+        return TryWrite(
+            $"Operation failed ({operation}):{Environment.NewLine}{Truncate(exception.ToString())}",
+            flushToDisk: true);
+    }
+
     public bool TryWriteUnhandledException(string source, Exception exception)
     {
         ArgumentException.ThrowIfNullOrWhiteSpace(source);

src/NoteManager.Core/ViewModels/MainViewModel.cs

@@ -13,6 +13,7 @@ public sealed class MainViewModel : ObservableObject, IDisposable
     private readonly RangeObservableCollection<NoteItem> _allNotes;
     private readonly RangeObservableCollection<NoteItem> _visibleNotes;
     private readonly InfostackerPublishingService _infostackerPublishingService;
+    private readonly ApplicationActivityLog _activityLog;
     private CancellationTokenSource? _indexCancellation;
     private CancellationTokenSource? _mediaRefreshCancellation;
     private CancellationTokenSource? _publishCancellation;
@@ -46,17 +47,24 @@ public sealed class MainViewModel : ObservableObject, IDisposable
     private const string UntaggedFilterKey = "__untagged__";
 
     public MainViewModel(
-        InfostackerPublishingService? infostackerPublishingService = null)
-        : this(infostackerPublishingService, useSampleDataForTesting: false)
+        InfostackerPublishingService? infostackerPublishingService = null,
+        ApplicationActivityLog? activityLog = null)
+        : this(
+            infostackerPublishingService,
+            activityLog,
+            useSampleDataForTesting: false)
     {
     }
 
     private MainViewModel(
         InfostackerPublishingService? infostackerPublishingService,
+        ApplicationActivityLog? activityLog,
         bool useSampleDataForTesting)
     {
         _infostackerPublishingService =
             infostackerPublishingService ?? new InfostackerPublishingService();
+        // Share failures are recoverable, but still need the application log's full exception details.
+        _activityLog = activityLog ?? new ApplicationActivityLog();
         _allNotes = new RangeObservableCollection<NoteItem>();
         _visibleNotes = new RangeObservableCollection<NoteItem>();
         NavigationItems = [];
@@ -97,8 +105,9 @@ private MainViewModel(
     /// need representative note data without opening a user folder.
     /// </summary>
     public static MainViewModel CreateWithSampleDataForTesting(
-        InfostackerPublishingService? infostackerPublishingService = null)
-        => new(infostackerPublishingService, useSampleDataForTesting: true);
+        InfostackerPublishingService? infostackerPublishingService = null,
+        ApplicationActivityLog? activityLog = null)
+        => new(infostackerPublishingService, activityLog, useSampleDataForTesting: true);
 
     public ObservableCollection<NavigationItem> NavigationItems { get; }
     public ObservableCollection<NoteItem> NotesView => _visibleNotes;
@@ -850,6 +859,8 @@ private static void DeleteCopiedImports(IEnumerable<ImportedPdf> importedPdfs)
         }
         catch (InfostackerPublishingException exception)
         {
+            // Preserve the wrapped transport or parsing cause while the dialog shows a friendly message.
+            _activityLog.TryWriteOperationFailure("Publishing a public link", exception);
             ShareStatusText = exception.Message;
             SetStatus(exception.Message);
             return null;
@@ -868,8 +879,12 @@ public void ConfirmPublicLinkCopied(string publicUrl)
         SetStatus($"Published note to Infostacker: {publicUrl}");
     }
 
-    public void ReportClipboardFailure(string message)
+    public void ReportClipboardFailure(string message, Exception? exception = null)
     {
+        // Clipboard failures occur after publishing, so record them separately from upload failures.
+        _activityLog.TryWriteOperationFailure(
+            "Copying a public link to the clipboard",
+            exception ?? new InvalidOperationException(message));
         ShareStatusText =
             $"The note was published, but the public link could not be copied: {message}";
         SetStatus("Note published, but copying the public link failed");

src/NoteManager.Desktop/Dialogs/ShareDialog.axaml

@@ -1,3 +1,4 @@
+<!-- Keep the modal sharing workflow visible instead of allowing it to be hidden in the taskbar. -->
 <Window xmlns="https://github.com/avaloniaui"
         xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
         xmlns:desktop="using:NoteManager.Desktop"
@@ -6,6 +7,7 @@
         Width="640"
         Height="250"
         CanResize="False"
+        CanMinimize="False"
         Background="{DynamicResource AppBackgroundBrush}"
         WindowStartupLocation="CenterOwner"
         Title="Share note">

src/NoteManager.Desktop/Dialogs/ShareDialog.axaml.cs

@@ -46,7 +46,8 @@ private async void Publish_OnClick(object? sender, RoutedEventArgs e)
         }
         catch (Exception exception)
         {
-            ViewModel.ReportClipboardFailure(exception.Message);
+            // Pass the exception so the application log retains its complete clipboard failure details.
+            ViewModel.ReportClipboardFailure(exception.Message, exception);
         }
     }
 

tests/NoteManager.App.Tests/StartupDataTests.cs

@@ -88,6 +88,48 @@ public void ApplicationActivityLog_RecordsUnhandledExceptionTypeMessageAndStack(
         }
     }
 
+    [Fact]
+    public void ApplicationActivityLog_RecordsHandledPublishFailureWithInnerException()
+    {
+        var logDirectory = Path.Combine(
+            Path.GetTempPath(),
+            $"NoteManager.ApplicationActivityLogPublish.{Guid.NewGuid():N}");
+
+        try
+        {
+            Exception caught;
+            try
+            {
+                throw new InvalidOperationException(
+                    "Publishing failed",
+                    new HttpRequestException("The sharing service could not be reached."));
+            }
+            catch (InvalidOperationException exception)
+            {
+                caught = exception;
+            }
+
+            // Recoverable sharing errors must retain their underlying network cause in the daily log.
+            Assert.True(new ApplicationActivityLog(logDirectory)
+                .TryWriteOperationFailure("Publishing a public link", caught));
+
+            var text = File.ReadAllText(Path.Combine(
+                logDirectory,
+                $"{ApplicationActivityLog.LogFilePrefix}{DateTime.Today:yyyy-MM-dd}.log"));
+            Assert.Contains("Operation failed (Publishing a public link):", text);
+            Assert.Contains("System.InvalidOperationException: Publishing failed", text);
+            Assert.Contains("System.Net.Http.HttpRequestException", text);
+            Assert.Contains("The sharing service could not be reached.", text);
+        }
+        finally
+        {
+            if (Directory.Exists(logDirectory))
+            {
+                Directory.Delete(logDirectory, recursive: true);
+            }
+        }
+    }
+
     [Fact]
     public void ApplicationActivityLog_TruncatesOversizedCrashText()
     {