From 8c8117a3ec92a8f9265614806f98ddcf8c767cc7 Mon Sep 17 00:00:00 2001
From: PedroHenrique0713 <pluspedrohenrique@gmail.com>
Date: Thu, 23 Jul 2026 17:59:34 -0300
Subject: [PATCH] fix(storage): wrap non-StorageError exceptions in
 StorageUnknownError

handleOperation's documented contract is to return { data, error } tuples.
When a non-StorageError was thrown, the error was re-thrown instead of
being wrapped, breaking the expected caller contract.
---
 packages/core/storage-js/src/lib/common/BaseApiClient.ts | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/packages/core/storage-js/src/lib/common/BaseApiClient.ts b/packages/core/storage-js/src/lib/common/BaseApiClient.ts
index fbe9e38e49..5edf81de50 100644
--- a/packages/core/storage-js/src/lib/common/BaseApiClient.ts
+++ b/packages/core/storage-js/src/lib/common/BaseApiClient.ts
@@ -1,4 +1,4 @@
-import { ErrorNamespace, isStorageError, StorageError } from './errors'
+import { ErrorNamespace, isStorageError, StorageError, StorageUnknownError } from './errors'
 import { Fetch } from './fetch'
 import { normalizeHeaders, setHeader as setHeaderUtil } from './headers'
 import { resolveFetch } from './helpers'
@@ -98,7 +98,10 @@ export default abstract class BaseApiClient<TError extends StorageError = Storag
       if (isStorageError(error)) {
         return { data: null, error: error as TError }
       }
-      throw error
+      return {
+        data: null,
+        error: new StorageUnknownError(_getErrorMessage(error), error) as unknown as TError,
+      }
     }
   }
 }