Skip to content

Continue Improvements to PWM Interface#167

Open
AdinAck wants to merge 1 commit into
stm32-rs:masterfrom
AdinAck:master
Open

Continue Improvements to PWM Interface#167
AdinAck wants to merge 1 commit into
stm32-rs:masterfrom
AdinAck:master

Conversation

@AdinAck
Copy link
Copy Markdown
Contributor

@AdinAck AdinAck commented Aug 18, 2023

Motivation

Now that the interface to create complementary PWM channels is exposed, it should include controlling the dead time as well.

Change(s) Description

  • Add set_dead_time function to complementary channels, provided by the ComplementaryPwm trait
  • Fix typo in set up of complementary channels

Testing

It works.

Limitations

The implementation I've made for now does not include any of the fancy multiplier capabilities the BDTR register provides. This only allows the dead time to be from 0-7 clock cycles.

Future

  • I hope to add an interface for setting PWM channels (complementary or not) to be center aligned.
  • More examples

Comment thread CHANGELOG.md Outdated
Comment thread examples/adc_values.rs
@therealprof
Copy link
Copy Markdown
Member

Would you please rebase the PR to get rid of the merge (and maybe some of the intermediate sausage making)?

@AdinAck AdinAck force-pushed the master branch 2 times, most recently from 7755c13 to 5ef7017 Compare September 30, 2023 23:51
- dead time
- fix typo
- update changelog
@AdinAck
Copy link
Copy Markdown
Contributor Author

AdinAck commented Nov 25, 2023

#170 will fix this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants