Repository navigation
Timed out event is still buffered #4318
Description
Describe the bug
For a timed out event, If connection between client and server is disrupted but not closed yet, client still buffers event.
To Reproduce
1- After connection between client and server is established disconnect the network.
2- before the client closes the connection send an event with timeout.
3- after the event times out connect the network.
4- client still sends the timed out event
Socket.IO server version: 4.4.1
Server
import { Server } from "socket.io";
const port = 3000;
const io = new Server(port);
console.log(`listening to ${port}`);
io.on("connection", (socket) => {
console.log('user connected');
socket.on("emited", (cb) => {
console.log('got event');
cb('done');
});
});
});Socket.IO client version: 4.4.1
Client
import { io } from "socket.io-client";
const socket = io("ws://server-ip:3000");
// send a message to the server
setTimeout(() => {
socket.timeout(1000).emit("emited", (err, msg) => {
if (err) {
console.log(err);
return;
}
console.log(msg);
});
console.log('event sent');
}, 10000);Expected behavior
After the event times out, the event should have been removed from buffer so it wouldn't be sent to server.
Platform:
- OS:Ubuntu 20.04
Activity
darrachequesne commentedon Mar 21, 2022
Hi! I wasn't able to reproduce the issue:
If you start the server after a few seconds, only 1st and 3rd events gets through. Isn't that the case for you?
The timed out events are removed here: https://github.com/socketio/socket.io-client/blob/eaf782c41b9b92d4f39aa221a4166de4a30fb560/lib/socket.ts#L207-L217
shayanYousefi commentedon Apr 3, 2022
Hi
Yes, If the server is restarted or started after the client you are right. the 2nd event is removed correctly. but if connection between server and client is established completely and server is not restarted THEN you make it so that all events are buffered in client, the 2nd event is not removed.
The way I buffer the events is by using a second pc for server. after connection is established and before events are sent (with a
setTimeoutforemit()) I turn off wired connection, then after second event times out I reconnect it. but I could not figure out how to reproduce that with one pc.this is the code and log used for server and client, if it helps:
client code :
server code:
client log:
server log:
darrachequesne commentedon Apr 5, 2022
I think this might indeed happen if the packets are buffered in the underlying Engine.IO client. The WebSocket connection is not really closed, so the packets are not discarded and they are sent once the connection is healthy again.
sercangoger commentedon Dec 26, 2023
Hello, I also have a problem regarding this issue.
I am working locally and I have a code like below.
//timeout func mandatory
IO.timeout(2000).to(driverId).emit("catch", "TAKSIISTEGI", (err, resp) => {
I run this code and it falls into the if block.
But when I go to postman and look, I see that it sent the data.
It sends the data but cannot say that it was sent successfully. It throws an error instead
"
err : Error: operation has timed out
at Timeout._onTimeout (/Users/gospeed/Documents/Backend/gospeed-websocket-socketio/node_modules/socket.io/dist/broadcast-operator.js:181:30)
at listOnTimeout (node:internal/timers:573:17)
at process.processTimers (node:internal/timers:514:7)
"
fix(client): close transport when volatile packet with timeout times out