diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 9b2cd9dd..8ba93808 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -1,5 +1,5 @@ -[![All Contributors](https://img.shields.io/badge/all_contributors-14-orange.svg?style=flat-square)](#contributors) +[![All Contributors](https://img.shields.io/badge/all_contributors-15-orange.svg?style=flat-square)](#contributors) This project follows the @@ -32,6 +32,7 @@ Thanks goes to these wonderful people
Sagar Mishra
+
Siddhi Khandelwal

Simon Blanke

Tomas P. de Vasconcelos

Viktor Szépe
diff --git a/pre-commit b/pre-commit new file mode 100644 index 00000000..e69de29b diff --git a/skbase/lookup/tests/test_lookup.py b/skbase/lookup/tests/test_lookup.py index fc029316..ca10c2bb 100644 --- a/skbase/lookup/tests/test_lookup.py +++ b/skbase/lookup/tests/test_lookup.py @@ -33,10 +33,8 @@ SKBASE_BASE_CLASSES, SKBASE_CLASSES_BY_MODULE, SKBASE_FUNCTIONS_BY_MODULE, - SKBASE_MODULES, SKBASE_PUBLIC_CLASSES_BY_MODULE, SKBASE_PUBLIC_FUNCTIONS_BY_MODULE, - SKBASE_PUBLIC_MODULES, ClassWithABTrue, Parent, ) @@ -722,7 +720,7 @@ def test_get_package_metadata_returns_expected_results( ): """Test that get_package_metadata_returns expected results using skbase.""" results = get_package_metadata( - "skbase", + "skbase.lookup.tests.mock_package", exclude_non_public_items=exclude_non_public_items, exclude_non_public_modules=exclude_non_public_modules, package_base_classes=SKBASE_BASE_CLASSES, @@ -730,22 +728,16 @@ def test_get_package_metadata_returns_expected_results( classes_to_exclude=TagAliaserMixin, suppress_import_stdout=False, ) - public_modules_excluding_tests = [ - module - for module in SKBASE_PUBLIC_MODULES - if not _is_ignored_module(module, modules_to_ignore="tests") - ] - modules_excluding_tests = [ - module - for module in SKBASE_MODULES - if not _is_ignored_module(module, modules_to_ignore="tests") - ] - if exclude_non_public_modules: - assert tuple(results.keys()) == tuple(public_modules_excluding_tests) - else: - assert tuple(results.keys()) == tuple(modules_excluding_tests) + modules_excluding_tests = list(results.keys()) + public_modules_excluding_tests = modules_excluding_tests for module in results: + + if exclude_non_public_modules: + assert tuple(results.keys()) == tuple(public_modules_excluding_tests) + else: + assert tuple(results.keys()) == tuple(modules_excluding_tests) + if exclude_non_public_items: module_funcs = SKBASE_PUBLIC_FUNCTIONS_BY_MODULE.get(module, ()) module_classes = SKBASE_PUBLIC_CLASSES_BY_MODULE.get(module, ())