Add gossip validation spec tests for proposer/attester slashings #9323
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -174,6 +174,17 @@ impl<E: EthSpec> FailedAtt<E> { | |
| } | ||
| } | ||
|
|
||
| /// `MessageAcceptance` doesn't implement clone so we do a manual match here. | ||
| /// TODO: remove this once `Clone` is available on this type: | ||
| /// https://github.com/libp2p/rust-libp2p/pull/6445 | ||
| fn clone_message_acceptance(a: &MessageAcceptance) -> MessageAcceptance { | ||
| match a { | ||
| MessageAcceptance::Accept => MessageAcceptance::Accept, | ||
| MessageAcceptance::Reject => MessageAcceptance::Reject, | ||
| MessageAcceptance::Ignore => MessageAcceptance::Ignore, | ||
| } | ||
| } | ||
|
|
||
| impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> { | ||
| /* Auxiliary functions */ | ||
|
|
||
|
|
@@ -2190,111 +2201,134 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> { | |
| message_id: MessageId, | ||
| peer_id: PeerId, | ||
| proposer_slashing: ProposerSlashing, | ||
| ) -> MessageAcceptance { | ||
| let validator_index = proposer_slashing.signed_header_1.message.proposer_index; | ||
|
|
||
| let (validation_result, verified_slashing_opt) = match self | ||
| .chain | ||
| .verify_proposer_slashing_for_gossip(proposer_slashing) | ||
| { | ||
| Ok(ObservationOutcome::New(slashing)) => (MessageAcceptance::Accept, Some(slashing)), | ||
| Ok(ObservationOutcome::AlreadyKnown) => { | ||
| debug!( | ||
| reason = "Already seen a proposer slashing for that validator", | ||
| validator_index, | ||
| peer = %peer_id, | ||
| "Dropping proposer slashing" | ||
| ); | ||
| (MessageAcceptance::Ignore, None) | ||
| } | ||
| Err(e) => { | ||
| debug!( | ||
| validator_index, | ||
| %peer_id, | ||
| error = ?e, | ||
| "Dropping proposer slashing due to an error" | ||
| ); | ||
|
|
||
| if matches!(e, BeaconChainError::ProposerSlashingValidationError(_)) { | ||
| // Penalize peer slightly for invalids. | ||
| self.gossip_penalize_peer( | ||
| peer_id, | ||
| PeerAction::HighToleranceError, | ||
| "invalid_gossip_proposer_slashing", | ||
| ); | ||
|
Comment on lines
+2230
to
+2235
Member
There was a problem hiding this comment. Is it intentional that this now only happens on My intuition would actually keep or remove a Dito for attestatiion slashings.
Member
Author
There was a problem hiding this comment. My original intention was to not change any scoring logic in this PR unless it's not compliant with the spec. However, it doesn't really make sense to penalize peer if the node fails to load the head state at current slot (peer has nothing to do with it) - so I removed that but maintain the current
Member
Author
There was a problem hiding this comment. FYI the penalty was originally introduced here a long while ago: #1602 |
||
| (MessageAcceptance::Reject, None) | ||
| } else { | ||
| // This is likely a fault with the beacon chain and not necessarily a | ||
| // malicious message from the peer. | ||
| (MessageAcceptance::Ignore, None) | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| self.propagate_validation_result( | ||
| message_id, | ||
| peer_id, | ||
| clone_message_acceptance(&validation_result), | ||
| ); | ||
|
|
||
| if let Some(slashing) = verified_slashing_opt { | ||
| metrics::inc_counter(&metrics::BEACON_PROCESSOR_PROPOSER_SLASHING_VERIFIED_TOTAL); | ||
|
|
||
| // Register the slashing with any monitored validators. | ||
| self.chain | ||
| .validator_monitor | ||
| .read() | ||
| .register_gossip_proposer_slashing(slashing.as_inner()); | ||
|
|
||
| self.chain.import_proposer_slashing(slashing); | ||
| debug!("Successfully imported proposer slashing"); | ||
|
|
||
| metrics::inc_counter(&metrics::BEACON_PROCESSOR_PROPOSER_SLASHING_IMPORTED_TOTAL); | ||
| } | ||
|
|
||
| validation_result | ||
| } | ||
|
|
||
| pub fn process_gossip_attester_slashing( | ||
| self: &Arc<Self>, | ||
| message_id: MessageId, | ||
| peer_id: PeerId, | ||
| attester_slashing: AttesterSlashing<T::EthSpec>, | ||
| ) -> MessageAcceptance { | ||
| let (validation_result, verified_slashing_opt) = match self | ||
| .chain | ||
| .verify_attester_slashing_for_gossip(attester_slashing) | ||
| { | ||
| Ok(ObservationOutcome::New(slashing)) => (MessageAcceptance::Accept, Some(slashing)), | ||
| Ok(ObservationOutcome::AlreadyKnown) => { | ||
| debug!( | ||
| reason = "Slashings already known for all slashed validators", | ||
| peer = %peer_id, | ||
| "Dropping attester slashing" | ||
| ); | ||
| (MessageAcceptance::Ignore, None) | ||
| } | ||
| Err(e) => { | ||
| debug!( | ||
| %peer_id, | ||
| error = ?e, | ||
| "Dropping attester slashing due to an error" | ||
| ); | ||
|
|
||
| if matches!(e, BeaconChainError::AttesterSlashingValidationError(_)) { | ||
| // Penalize peer slightly for invalids. | ||
| self.gossip_penalize_peer( | ||
| peer_id, | ||
| PeerAction::HighToleranceError, | ||
| "invalid_gossip_attester_slashing", | ||
| ); | ||
| (MessageAcceptance::Reject, None) | ||
| } else { | ||
| // This is likely a fault with the beacon chain and not necessarily a | ||
| // malicious message from the peer. | ||
| (MessageAcceptance::Ignore, None) | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| self.propagate_validation_result( | ||
| message_id, | ||
| peer_id, | ||
| clone_message_acceptance(&validation_result), | ||
| ); | ||
|
|
||
| if let Some(slashing) = verified_slashing_opt { | ||
| metrics::inc_counter(&metrics::BEACON_PROCESSOR_ATTESTER_SLASHING_VERIFIED_TOTAL); | ||
|
|
||
| // Register the slashing with any monitored validators. | ||
| self.chain | ||
| .validator_monitor | ||
| .read() | ||
| .register_gossip_attester_slashing(slashing.as_inner().to_ref()); | ||
|
|
||
| self.chain.import_attester_slashing(slashing); | ||
| debug!("Successfully imported attester slashing"); | ||
| metrics::inc_counter(&metrics::BEACON_PROCESSOR_ATTESTER_SLASHING_IMPORTED_TOTAL); | ||
| } | ||
|
|
||
| validation_result | ||
| } | ||
|
|
||
| pub fn process_gossip_bls_to_execution_change( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof. I opened libp2p/rust-libp2p#6445, let's add a comment here to remove this fn once that is available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, added comment