From bb454ff0e093a78dbababa0ec24999801af97422 Mon Sep 17 00:00:00 2001 From: Loris Janner Date: Wed, 15 Apr 2026 17:03:12 +0200 Subject: [PATCH] feat(element-theme): align ghost button naming convention `.btn-ghost` now represents the primary ghost button style, consistent with the naming convention established by `.btn-secondary-ghost` and `.btn-tertiary-ghost`. All internal usages of the old `.btn-ghost` (which had tertiary ghost styling) have been migrated to `.btn-tertiary-ghost`. The transitional `.btn-primary-ghost` class introduced in v49.5.0 has been removed. Resolves #1797 BREAKING CHANGE: `.btn-ghost` no longer applies tertiary ghost styling. When using `.btn-ghost` as a tertiary ghost button it must be renamed to `.btn-tertiary-ghost`. A schematic migration will be provided to automate this update. --- docs/components/layout-navigation/modals.md | 2 +- .../e2e/element-examples/si-tabs-legacy.spec.ts | 2 +- .../custom-widget-catalog.component.html | 2 +- .../si-alert-dialog/si-alert-dialog.component.html | 2 +- .../si-confirmation-dialog.component.html | 2 +- .../si-delete-confirmation-dialog.component.html | 2 +- .../si-edit-discard-dialog.component.html | 2 +- .../launchpad/si-launchpad-factory.component.html | 2 +- .../chat-messages/si-ai-message.component.html | 4 ++-- .../si-attachment-list.component.html | 2 +- .../chat-messages/si-chat-input.component.html | 8 ++++---- .../chat-messages/si-user-message.component.html | 4 ++-- .../si-column-selection-dialog.component.html | 2 +- .../si-timeline-widget-item.component.html | 4 ++-- .../file-uploader/si-file-uploader.component.html | 2 +- .../filter-bar/si-filter-pill.component.html | 2 +- .../si-filtered-search-value.component.html | 2 +- .../si-filtered-search.component.html | 2 +- .../si-loading-button.component.scss | 2 +- .../si-navbar-vertical-next.component.html | 2 +- .../si-navbar-vertical.component.html | 2 +- .../si-notification-item.component.html | 8 ++++---- .../photo-upload/si-photo-upload.component.html | 2 +- .../pills-input/si-input-pill.component.html | 6 +++++- .../pills-input/si-pills-input.component.spec.ts | 4 ++-- .../search-bar/si-search-bar.component.html | 2 +- .../si-side-panel-content.component.html | 10 +++++----- .../si-tabset/si-tabset-legacy.component.html | 2 +- projects/element-ng/tabs/si-tab.component.html | 2 +- .../threshold/si-threshold.component.html | 2 +- .../si-toast-notification.component.html | 2 +- projects/element-ng/tour/si-tour.component.html | 2 +- .../src/styles/bootstrap/_buttons.scss | 12 +++--------- src/app/examples/buttons/button-groups.html | 6 +++--- src/app/examples/buttons/buttons.html | 14 +++++++------- .../si-chat-messages/si-attachment-list.html | 2 +- .../si-chat-messages/si-chat-container.html | 4 ++-- .../examples/si-chat-messages/si-chat-input.html | 2 +- .../examples/si-chat-messages/si-chat-message.html | 6 +++--- .../si-dashboard/si-timeline-widget-body.ts | 2 +- .../examples/si-dashboard/si-timeline-widget.ts | 2 +- .../examples/si-datepicker/si-modal-service.html | 2 +- .../si-list-details/si-list-details-router.html | 2 +- .../examples/si-list-details/si-list-details.html | 2 +- .../si-loading-spinner/si-loading-button.html | 2 +- .../si-map/si-map-custom-cluster-popover.ts | 2 +- .../examples/si-modals/app-table.component.html | 2 +- src/app/examples/si-modals/si-modal-service.html | 6 +++--- src/app/examples/si-wizard/si-wizard-forms.html | 2 +- 49 files changed, 82 insertions(+), 84 deletions(-) diff --git a/docs/components/layout-navigation/modals.md b/docs/components/layout-navigation/modals.md index ddccfef067..ec64644466 100644 --- a/docs/components/layout-navigation/modals.md +++ b/docs/components/layout-navigation/modals.md @@ -79,7 +79,7 @@ import { viewChild } from '@angular/core'; diff --git a/playwright/e2e/element-examples/si-tabs-legacy.spec.ts b/playwright/e2e/element-examples/si-tabs-legacy.spec.ts index 3fc6659fb1..93aaecb6ac 100644 --- a/playwright/e2e/element-examples/si-tabs-legacy.spec.ts +++ b/playwright/e2e/element-examples/si-tabs-legacy.spec.ts @@ -11,7 +11,7 @@ test.describe('si-tabs', () => { await si.visitExample(example); await page.locator('si-tabset-legacy button').getByText('Reception').click(); await si.runVisualAndA11yTests(); - await page.locator('si-tabset-legacy .btn-ghost.close').first().click(); + await page.locator('si-tabset-legacy .btn-tertiary-ghost.close').first().click(); await expect(page.locator('#si-tabset button').getByText('Reception')).toHaveCount(0); await si.runVisualAndA11yTests('delete'); }); diff --git a/projects/dashboards-demo/src/app/components/widget-catalog/custom-widget-catalog.component.html b/projects/dashboards-demo/src/app/components/widget-catalog/custom-widget-catalog.component.html index 71c902fd39..a222517eda 100644 --- a/projects/dashboards-demo/src/app/components/widget-catalog/custom-widget-catalog.component.html +++ b/projects/dashboards-demo/src/app/components/widget-catalog/custom-widget-catalog.component.html @@ -2,7 +2,7 @@ Custom Catalog } @else if (action.type === 'router-link') { } @else if (action.type === 'link') { - - diff --git a/src/app/examples/buttons/buttons.html b/src/app/examples/buttons/buttons.html index 1e8c8a8cd0..08216543c5 100644 --- a/src/app/examples/buttons/buttons.html +++ b/src/app/examples/buttons/buttons.html @@ -4,7 +4,7 @@ - + - @@ -180,7 +180,7 @@

Circle buttons

@@ -243,7 +243,7 @@

Circle buttons

@@ -333,7 +333,7 @@

Button links

Danger Link - + Ghost Link diff --git a/src/app/examples/si-chat-messages/si-attachment-list.html b/src/app/examples/si-chat-messages/si-attachment-list.html index 1a541bf4fe..299f3e2eff 100644 --- a/src/app/examples/si-chat-messages/si-attachment-list.html +++ b/src/app/examples/si-chat-messages/si-attachment-list.html @@ -17,7 +17,7 @@ diff --git a/src/app/examples/si-list-details/si-list-details.html b/src/app/examples/si-list-details/si-list-details.html index d18db6d3b0..1da536210e 100644 --- a/src/app/examples/si-list-details/si-list-details.html +++ b/src/app/examples/si-list-details/si-list-details.html @@ -38,7 +38,7 @@ /> diff --git a/src/app/examples/si-loading-spinner/si-loading-button.html b/src/app/examples/si-loading-spinner/si-loading-button.html index 1387edcd67..c38c979916 100644 --- a/src/app/examples/si-loading-spinner/si-loading-button.html +++ b/src/app/examples/si-loading-spinner/si-loading-button.html @@ -69,7 +69,7 @@ (click)="handleClick('circle button')" />