This repository was archived by the owner on Nov 23, 2024. It is now read-only.
去除有关 join_all 性能问题的推荐#10
Merged
Merged
Conversation
pan93412
approved these changes
May 1, 2022
upsuper
reviewed
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-lang/futures-rs#2412 中引入的修改使得
futures::future::join_all在遇到大量或不定数量的Future时使用FutureOrdered实现，避免了全量poll带来的开销。考虑到join系列函数并不能动态插入Future来poll，这里依然保留了FuturesOrdered/FuturesUnordered的介绍，并略微修改了一下说明。