Skip to content

web: Fix MVP wasm build by explicitly disabling post-MVP features #23756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
torokati44 merged 1 commit into from
May 20, 2026
+21 −7
Merged

web: Fix MVP wasm build by explicitly disabling post-MVP features #23756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions web/packages/core/tools/build_wasm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,27 @@ function cargoBuild({
if (process.env["CARGO_FLAGS"]) {
args = args.concat(process.env["CARGO_FLAGS"].split(" "));
}
execFileSync("cargo", args, {
env: Object.assign(Object.assign({}, process.env), {
Comment thread
torokati44 marked this conversation as resolved.
RUSTFLAGS: totalRustFlags,
RUSTC_BOOTSTRAP: extensions ? "0" : "1",
}),
stdio: "inherit",
});
const env: NodeJS.ProcessEnv = {
...process.env,
RUSTFLAGS: totalRustFlags,
RUSTC_BOOTSTRAP: extensions ? "0" : "1",
};

if (!extensions) {
// C dependencies (e.g. jpegxr's jxrlib) are compiled by cc-rs/clang,
// whose default wasm32 target enables post-MVP features like
// reference-types and multivalue. Those bits end up in the linked
// module's target_features section, which makes wasm-bindgen attempt
// externref transforms and then fail with "failed to find the
// __wbindgen_externref_table_dealloc function". Force clang to MVP too.
// See: https://github.com/ruffle-rs/ruffle/issues/23751
// and: https://github.com/wasm-bindgen/wasm-bindgen/issues/4654
env["CFLAGS_wasm32_unknown_unknown"] ??= "";
env["CFLAGS_wasm32_unknown_unknown"] +=
" -mno-reference-types -mno-multivalue";
}

execFileSync("cargo", args, { env, stdio: "inherit" });
}
function buildWasm(
profile: string,
Expand Down
Loading