Update linting configuration and remove unnecessary skip conditions for Windows

Author: yuriverweij

.gitattibutes

@@ -0,0 +1 @@
+*.approved.txt text eol=lf

utest/test/api/approved_files/PluginDocumentation.test_many_plugins.approved.txt

@@ -528,18 +528,18 @@ Example project for translation can be found from
 [https://github.com/MarketSquare/robotframework-seleniumlibrary-translation-fi | robotframework-seleniumlibrary-translation-fi]
 repository.
 
-= Plugin: my_lib =
+= Plugin: MyLib =
 
 Some dummy documentation.
 
-= my_lib Heading 1 =
+= MyLib Heading 1 =
 
 This is heading 1 documentation.
 
-== my_lib Heading 2 ==
+== MyLib Heading 2 ==
 
  This is heading 2 documentation.
 
-= Plugin: my_lib_args =
+= Plugin: MyLibArgs =
 
 No plugin documentation found.

utest/test/api/test_filepath_unusual_characters.py

@@ -21,7 +21,6 @@ def reporter():
     return factory.get_first_working()
 
 
-@pytest.mark.skipif(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_normal_file_path(reporter):
     results = []
     results.append(_format_path("/foo/file.log", 1))

utest/test/api/test_plugin_documentation.py

@@ -30,19 +30,16 @@ def setUp(self):
             factory.get_first_working(), PythonNativeReporter()
         )
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_many_plugins(self):
         sl = SeleniumLibrary(
             plugins=f"{self.plugin_1}, {self.plugin_3};arg1=Text1;arg2=Text2"
         )
         verify(sl.get_keyword_documentation("__intro__"), self.reporter)
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_parse_plugin_init_doc(self):
         sl = SeleniumLibrary(plugins=f"{self.plugin_3};arg1=Text1;arg2=Text2")
         verify(sl.get_keyword_documentation("__init__"), self.reporter)
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_parse_plugin_kw_doc(self):
         sl = SeleniumLibrary(plugins=f"{self.plugin_3};arg1=Text1;arg2=Text2")
         verify(sl.get_keyword_documentation("execute_javascript"), self.reporter)

utest/test/keywords/test_firefox_profile_parsing.py

@@ -27,7 +27,6 @@ def setUpClass(cls):
     def setUp(self):
         self.results = []
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_single_method(self):
         self._parse_result(
             self.creator._get_ff_profile('set_preference("key1", "arg1")')

utest/test/keywords/test_javascript.py

@@ -12,7 +12,6 @@
 
 class JavaScriptKeywordsTest(unittest.TestCase):
     @classmethod
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def setUpClass(cls):
         cls.code_examples = [
             (),
@@ -40,13 +39,11 @@ def setUpClass(cls):
         factory.load(reporter_json)
         cls.reporter = factory.get_first_working()
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_get_javascript(self):
         code, args = self.js._get_javascript_to_execute(("code", "here"))
         result = f"{code} + {args}"
         verify(result, self.reporter)
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_get_javascript_no_code(self):
         code = ("ARGUMENTS", "arg1", "arg1")
         try:
@@ -55,21 +52,18 @@ def test_get_javascript_no_code(self):
             result = str(error)
         verify(result, self.reporter)
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_separate_code_and_args(self):
         all_results = []
         for code in self.code_examples:
             all_results.append(self.js_reporter(code))
         verify_all("code and args", all_results, reporter=self.reporter)
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_indexing(self):
         all_results = []
         for code in self.code_examples:
             all_results.append(self.js._get_marker_index(code))
         verify_all("index", all_results, reporter=self.reporter)
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_check_marker_error(self):
         examples = [
             (),

utest/test/keywords/test_press_keys.py

@@ -24,7 +24,6 @@ def setUp(self):
         factory.load(reporter_json)
         self.reporter = factory.get_first_working()
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_parse_keys(self):
         results = []
         results.append(self.element_keywords._parse_keys("A", "B", "C"))
@@ -41,7 +40,6 @@ def test_parse_keys(self):
         results.append(self.element_keywords._parse_keys("IS", "ALT", "HERE"))
         verify_all("index", results, reporter=self.reporter)
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_parse_keys_aliases(self):
         results = []
         results.append(self.element_keywords._parse_aliases("CTRL"))
@@ -51,7 +49,6 @@ def test_parse_keys_aliases(self):
         results.append(self.element_keywords._parse_aliases("END"))
         verify_all("Alias testing", results, reporter=self.reporter)
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_separate_key(self):
         results = []
         results.append(self.element_keywords._separate_key("BB"))
@@ -65,7 +62,6 @@ def test_separate_key(self):
         results.append(self.element_keywords._separate_key("+++"))
         verify_all("Separate key", results, reporter=self.reporter)
 
-    @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
     def test_convert_key(self):
         results = []
         results.append(self.element_keywords._convert_special_keys(["B"]))

utest/test/keywords/test_selenium_options_parser.py

@@ -33,7 +33,6 @@ def teardown_function():
     unstub()
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_parse_options_string(options, reporter):
     results = []
     results.append(options._parse('method("arg1")'))
@@ -72,7 +71,6 @@ def test_parse_options_string(options, reporter):
     verify_all("Selenium options string to dict", results, reporter=reporter)
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_index_of_separator(options, reporter):
     results = []
     results.append(options._get_arument_index('method({"key": "value"})'))
@@ -82,7 +80,6 @@ def test_index_of_separator(options, reporter):
     verify_all("Get argument index", results, reporter=reporter)
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_parse_complex_object(options, reporter):
     results = []
     results.append(options._parse_to_tokens('method({"key": "value"})'))
@@ -92,7 +89,6 @@ def test_parse_complex_object(options, reporter):
     verify_all("Parse complex Python object", results, reporter=reporter)
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_parse_arguemnts(options, reporter):
     results = []
     results.append(options._parse_arguments(("arg1",), True))
@@ -103,7 +99,6 @@ def test_parse_arguemnts(options, reporter):
     verify_all("Parse arguments from complex object", results, reporter=reporter)
 
 
-@pytest.mark.skipif(WINDOWS, reason="ApprovalTest do not support different line feeds")
 @pytest.mark.skipif(sys.version_info > (3, 11), reason="Errors change with Python 3.12")
 def test_parse_options_string_errors(options, reporter):
     results = []
@@ -116,7 +111,6 @@ def test_parse_options_string_errors(options, reporter):
     verify_all("Selenium options string errors", results, reporter=reporter)
 
 
-@pytest.mark.skipif(WINDOWS, reason="ApprovalTest do not support different line feeds")
 @pytest.mark.skipif(sys.version_info < (3, 12), reason="Errors change with Python 3.12")
 def test_parse_options_string_errors_py3_12(options, reporter):
     results = []
@@ -129,7 +123,6 @@ def test_parse_options_string_errors_py3_12(options, reporter):
     verify_all("Selenium options string errors", results, reporter=reporter)
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_split_options(options, reporter):
     results = []
     results.append(options._split('method("arg1");method("arg2")'))
@@ -143,7 +136,6 @@ def test_split_options(options, reporter):
     verify_all("Selenium options string splitting", results, reporter=reporter)
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_options_create(options, reporter):
     results = []
     options_str = 'add_argument("--disable-dev-shm-usage")'
@@ -175,15 +167,13 @@ def test_options_create(options, reporter):
     verify_all("Selenium options", results, reporter=reporter)
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_get_options(options, reporter):
     options_str = 'add_argument("--proxy-server=66.97.38.58:80")'
     sel_options = options.create("chrome", options_str)
     results = [sel_options.arguments]
     verify_all("Selenium options with string.", results, reporter=reporter)
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_importer(options, reporter):
     results = []
     results.append(options._import_options("firefox"))

utest/test/keywords/test_selenium_service_parser.py

@@ -32,7 +32,6 @@ def teardown_function():
     unstub()
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_parse_service_string(service, reporter):
     results = []
     results.append(service._parse('attribute="arg1"'))
@@ -53,9 +52,6 @@ def test_parse_service_string(service, reporter):
     verify_all("Selenium service string to dict", results, reporter=reporter)
 
 
-# @unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
-# @unittest.skipIf(sys.version_info > (3, 11), reason="Errors change with Python 3.12")
-@pytest.mark.skipif(WINDOWS, reason="ApprovalTest do not support different line feeds")
 @pytest.mark.skipif(sys.version_info > (3, 11), reason="Errors change with Python 3.12")
 def test_parse_service_string_errors(service, reporter):
     results = []
@@ -68,7 +64,6 @@ def test_parse_service_string_errors(service, reporter):
     verify_all("Selenium service string errors", results, reporter=reporter)
 
 
-@pytest.mark.skipif(WINDOWS, reason="ApprovalTest do not support different line feeds")
 @pytest.mark.skipif(sys.version_info < (3, 12), reason="Errors change with Python 3.12")
 def test_parse_service_string_errors_py3_12(service, reporter):
     results = []
@@ -81,7 +76,6 @@ def test_parse_service_string_errors_py3_12(service, reporter):
     verify_all("Selenium service string errors", results, reporter=reporter)
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_split_service(service, reporter):
     results = []
     results.append(service._split("attribute='arg1'", ';'))
@@ -91,7 +85,6 @@ def test_split_service(service, reporter):
     verify_all("Selenium service string splitting", results, reporter=reporter)
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_split_attribute(service, reporter):
     results = []
     results.append(service._split("attribute='arg1'", '='))
@@ -100,7 +93,6 @@ def test_split_attribute(service, reporter):
     verify_all("Selenium service attribute string splitting", results, reporter=reporter)
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_service_create(service, reporter):
     results = []
     service_str = "service_args=['--log-level=DEBUG']"
@@ -118,7 +110,6 @@ def test_service_create(service, reporter):
     verify_all("Selenium service", results, reporter=reporter)
 
 
-@unittest.skipIf(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_importer(service, reporter):
     results = []
     results.append(service._import_service("firefox"))

utest/test/utils/test_xpath_escape.py

@@ -21,7 +21,6 @@ def reporter():
     return factory.get_first_working()
 
 
-@pytest.mark.skipif(WINDOWS, reason="ApprovalTest do not support different line feeds")
 def test_string(reporter):
     results = []
     results.append(escape_xpath_value("tidii"))