fixes for copilot review comments.

Co-authored-by: Copilot <copilot@github.com>

Author: yuriverweij

.gitattibutes .gitattributes.gitattibutes renamed to .gitattributes

@@ -125,12 +125,12 @@ Development commands
 
 Use `invoke`_ tasks for common local checks and test runs::
 
-    inv format --check    # Check formatting with Ruff
-    inv format            # Format source files with Ruff
-    inv lint              # Run Ruff lint checks
-    inv lint --fix        # Apply safe Ruff lint fixes
-    inv utest             # Run unit tests
-    inv atest             # Run acceptance tests (headlesschrome)
+    inv formatter --check    # Check formatting with Ruff
+    inv formatter            # Format source files with Ruff
+    inv lint                 # Run Ruff lint checks
+    inv lint --fix           # Apply safe Ruff lint fixes
+    inv utest                # Run unit tests
+    inv atest                # Run acceptance tests (headlesschrome)
 
 Run these before opening a pull request so local results are close to CI.
 Use the project virtual environment and pinned dependencies from

CONTRIBUTING.rst

@@ -40,7 +40,6 @@
 
 import platform
 import time
-from unittest import runner
 import zipfile
 from contextlib import contextmanager
 import os

atest/run.py

@@ -11,8 +11,6 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-import string
-
 from selenium.webdriver.support import expected_conditions as EC
 from selenium.webdriver.support.wait import WebDriverWait
 
@@ -23,7 +21,7 @@
 class ExpectedConditionKeywords(LibraryComponent):
     @keyword
     def wait_for_expected_condition(
-        self, condition: string, *args, timeout: float | None = 10
+        self, condition: str, *args, timeout: float | None = 10
     ):
         """Waits until ``condition`` is true or ``timeout`` expires.
 
@@ -64,5 +62,5 @@ def wait_for_expected_condition(
             message=f"Expected Condition not met within set timeout of {timeout}s",
         )
 
-    def _parse_condition(self, condition: string):
+    def _parse_condition(self, condition: str):
         return condition.replace(" ", "_").lower()

src/SeleniumLibrary/keywords/expectedconditions.py

@@ -63,8 +63,6 @@ def register_keyword_to_run_on_failure(self, keyword: str | None) -> str:
     def resolve_keyword(name):
         if name is None:
             return None
-        if (
-            isinstance(name, str) and name.upper() == "NOTHING"
-        ) or name.upper() == "NONE":
+        if isinstance(name, str) and name.upper() in ("NOTHING", "NONE"):
             return None
         return name

src/SeleniumLibrary/keywords/runonfailure.py

@@ -71,7 +71,9 @@ def set_screenshot_directory(self, path: None | str) -> str:
         return previous
 
     @keyword
-    def capture_page_screenshot(self, filename: str = DEFAULT_FILENAME_PAGE) -> str:
+    def capture_page_screenshot(
+        self, filename: str = DEFAULT_FILENAME_PAGE
+    ) -> str | None:
         """Takes a screenshot of the current page and embeds it into a log file.
 
         ``filename`` argument specifies the name of the file to write the
@@ -148,7 +150,7 @@ def capture_element_screenshot(
         self,
         locator: Locator,
         filename: str = DEFAULT_FILENAME_ELEMENT,
-    ) -> str:
+    ) -> str | None:
         """Captures a screenshot from the element identified by ``locator`` and embeds it into log file.
 
         See `Capture Page Screenshot` for details about ``filename`` argument.

src/SeleniumLibrary/keywords/screenshot.py

@@ -466,8 +466,6 @@ def _get_index(self, alias_or_index):
 
 
 class SeleniumService:
-    """ """
-
     def create(self, browser, service):
         if not service:
             return None

src/SeleniumLibrary/keywords/webdrivertools/webdrivertools.py

@@ -4,11 +4,10 @@
 import bs4
 from docutils.core import publish_cmdline
 from invoke import task
-from rellu import initialize_labels, ReleaseNotesGenerator, Version
+from rellu import ReleaseNotesGenerator, Version, initialize_labels
 from rellu.tasks import clean  # noqa
 from robot.libdoc import libdoc
 
-
 assert Path.cwd() == Path(__file__).parent
 
 VERSION_PATTERN = '__version__ = "(.*)"'
@@ -110,7 +109,7 @@ def project_docs(ctx):
         "docs/index.html",
     ]
     publish_cmdline(writer_name="html5", argv=args)
-    print(Path(args[-1]).absolute())
+    print(Path(args[-1]).absolute())  # noqa : T201
 
 
 @task
@@ -133,13 +132,13 @@ def set_version(ctx, version):
     """
     version = Version(version, VERSION_PATH, VERSION_PATTERN)
     version.write()
-    print(version)
+    print(version)  # noqa : T201
 
 
 @task
 def print_version(ctx):
     """Print the current project version."""
-    print(Version(path=VERSION_PATH))
+    print(Version(path=VERSION_PATH))  # noqa : T201
 
 
 @task
@@ -187,18 +186,18 @@ def init_labels(ctx, username=None, password=None):
 
 @task
 def lint(ctx, fix=False):
-    """Run Ruff lint checkse.
+    """Run Ruff lint checks.
 
     Args:
         fix: Apply safe fixes when True. Defaults to False.
     """
-    cmd = f"{sys.executable} -m ruff check --config pyproject.toml src/ utest/" # atest/"
+    cmd = f"{sys.executable} -m ruff check --config pyproject.toml tasks.py src/ utest/" # atest/"
     if fix:
         cmd = f"{cmd} --fix"
     ctx.run(cmd)
 
 @task
-def format(ctx, check=False):    
+def formatter(ctx, check=False):
     """Run Ruff formatter.
 
     Args: