Save not working on nested attributes

[reejosamuel]

Hi, Glad to see you are back and active again @remiprev

I have a model

class Branch

  include Her::Model

  belongs_to :Shop

  attributes  :email,         :address_line1,
             :address_line2, :landmark,      :pin,
             :phone,         :settlement_time
.... more stuff ..
end

and Shop.rb

class Shop
  include Her::Model

  has_many :branches

... more stuff....
end

and in the controller for Branches I'm doing a update action

 def update
    @shop = Shop.find(params[:merchant_id])
    @shop.branches.assign_attributes(branch_params)

    respond_to do |format|
      if @shop.branches.save
        format.html { redirect_to @branch, notice: 'Branch was successfully updated.' }
      else
        format.html { render :edit }
      end
    end
  end

This leads to undefined method "assign_attributes" for #<Her::Collection:0x00000106fc2860>

also If i try to do save on @branch then i calls PUT the url www.example.com/ branch/1 instead of www.example.com/ shop/1/branch/1

[pencil]

Not quite sure what your trying to achieve. What does branch_params look like? What is the expected behaviour? Where is @branch coming from?

also If i try to do save on @branch then i calls PUT the url www.example.com/branch/1 instead of www.example.com/shop/1/branch/1

Probably related to #238?

[reejosamuel]

branch_params is just a helper method for getting the params

    def branch_params
      params[:branch]
    end

[remi]

You need to customize the URL for your Branch model:

class Branch
  include Her::Model
  resource_path 'shop/:shop_id/branch/:id'
end

[reejosamuel]

So, you are saying i remove the associations, handle each Model separately? and use the resource_path. Is this is a temporary fix or the right way to go about with HER

This has sorted the issue. Thank you

[remi]

So, you are saying i remove the associations, handle each Model separately? and use the resource_path. Is this is a temporary fix or the right way to go about with HER

This is indeed the right way to do it. By default, Her assumes resources are located at the root of the base URL. We have to do it this way because users can specify multiple belong_to associations in their model:

class Branch
  include Her::Model
  belongs_to :shop
  belongs_to :user
end

There we cannot assume that the path will be /shops/:shop_id/branches/:id or /users/:user_id/branches/:id. That’s why users have to specify the path manually if they want to customize the default one.

I’m going to close the issue — feel free to re-open it if you have further questions.

[reejosamuel]

Personally i believe if the user has mentioned the belongs_to associations then he is actually expecting the url to be nested as per association and given how your gem has been keeping up the pattern it is very much expected. Also i saw a lot of users opening issues on this context.

Having collection_path and resource_path is a great alternative for people who wants to customize the URL.

Note that there is nothing mentioned in the readme documentation about the resource_path

[paulvt]

I agree with the above assement, however, setting a collection path changes it for the entire model, while it is only relevant for the association.

For example: a product may be associated to a few categories (/products/:product_id/categories/:category_id), which can be created/updated/destroyed there but this holds for the mere associations. There can be a /categories/:category_id where the actual all categories live. In this case, I cannot set the collection path to either one for model Category. Maybe it is better to have it configurable per association like:

class Product
  has_many :categories, use_parent_path: true  # uses /products/:product_id/categories/:category_id
  has_many :stocks # uses /stocks/:stock_id
end

See also #238.

[balvig]

Not sure if this helps but just for reference, with Spyke (our heavily Her-inspired gem) we are solving the problem like this:

https://github.com/balvig/spyke#custom-uris

A key difference though is that Spyke uses only one URI template (with optional urls segments) to handle both collection/resource, but I guess perhaps Her could be tweaked to allow both the :resource_path and :collection_path-options on the associations in a similar fashion?