From 426bc60853cb29a1bc2e3a4e84441e15530a2baf Mon Sep 17 00:00:00 2001
From: mimran-khan <mohammed_imran.khan@outlook.com>
Date: Thu, 12 Nov 2026 00:28:42 +0530
Subject: [PATCH 1/2] fix: require a comment with every thumbs-down

A down vote could be sent with an empty comment. Send stays disabled until the comment has text, and Enter does not submit a blank one.

Signed-off-by: mimran-khan <mohammed_imran.khan@outlook.com>
---
 .../components/FeedbackButtons.test.tsx       | 58 +++++++++++++++++++
 src/frontend/components/FeedbackButtons.tsx   | 19 ++++--
 2 files changed, 72 insertions(+), 5 deletions(-)
 create mode 100644 src/frontend/components/FeedbackButtons.test.tsx

diff --git a/src/frontend/components/FeedbackButtons.test.tsx b/src/frontend/components/FeedbackButtons.test.tsx
new file mode 100644
index 00000000..11de6d37
--- /dev/null
+++ b/src/frontend/components/FeedbackButtons.test.tsx
@@ -0,0 +1,58 @@
+import { fireEvent, render, screen } from '@testing-library/react';
+import { describe, expect, it, vi } from 'vitest';
+
+import { FeedbackCommentBox, type FeedbackState } from './FeedbackButtons';
+
+function commentState(comment: string): FeedbackState {
+  return {
+    existingFeedback: null,
+    isSubmitting: false,
+    showCommentInput: true,
+    comment,
+    disabled: false,
+    handleThumbsUp: vi.fn(),
+    handleThumbsDown: vi.fn(),
+    handleCommentSubmit: vi.fn(),
+    setComment: vi.fn(),
+    cancelComment: vi.fn(),
+  };
+}
+
+describe('FeedbackCommentBox', () => {
+  it('keeps Send disabled until the comment has text', () => {
+    const { rerender } = render(<FeedbackCommentBox fb={commentState('')} />);
+    const send = screen.getByRole('button', { name: 'Send' });
+    const comment = screen.getByRole('textbox', { name: 'What went wrong?' });
+
+    expect(comment).toBeRequired();
+    expect(send).toBeDisabled();
+
+    rerender(<FeedbackCommentBox fb={commentState('   ')} />);
+    expect(screen.getByRole('button', { name: 'Send' })).toBeDisabled();
+
+    rerender(<FeedbackCommentBox fb={commentState('The table was wrong')} />);
+    expect(screen.getByRole('button', { name: 'Send' })).toBeEnabled();
+  });
+
+  it('does not send a blank comment with Enter', () => {
+    const fb = commentState('   ');
+    render(<FeedbackCommentBox fb={fb} />);
+
+    fireEvent.keyDown(screen.getByRole('textbox', { name: 'What went wrong?' }), {
+      key: 'Enter',
+    });
+
+    expect(fb.handleCommentSubmit).not.toHaveBeenCalled();
+  });
+
+  it('sends when Enter is pressed on a real comment', () => {
+    const fb = commentState('The citation was wrong');
+    render(<FeedbackCommentBox fb={fb} />);
+
+    fireEvent.keyDown(screen.getByRole('textbox', { name: 'What went wrong?' }), {
+      key: 'Enter',
+    });
+
+    expect(fb.handleCommentSubmit).toHaveBeenCalledOnce();
+  });
+});
diff --git a/src/frontend/components/FeedbackButtons.tsx b/src/frontend/components/FeedbackButtons.tsx
index c3c2bc0f..f2d6a818 100644
--- a/src/frontend/components/FeedbackButtons.tsx
+++ b/src/frontend/components/FeedbackButtons.tsx
@@ -101,7 +101,9 @@ export function useFeedback({
   }, [locked, isSubmitting]);
 
   const handleCommentSubmit = useCallback(() => {
-    void doSendFeedback('down', comment.trim() || undefined);
+    const text = comment.trim();
+    if (!text) return;
+    void doSendFeedback('down', text);
   }, [doSendFeedback, comment]);
 
   const cancelComment = useCallback(() => {
@@ -164,10 +166,13 @@ export function FeedbackButtons({ fb }: { fb: FeedbackState }) {
 export function FeedbackCommentBox({ fb }: { fb: FeedbackState }) {
   if (!fb.showCommentInput || !!fb.existingFeedback) return null;
 
+  const commentText = fb.comment.trim();
+  const canSend = commentText.length > 0 && !fb.isSubmitting;
+
   const handleKeyDown = (e: React.KeyboardEvent<HTMLTextAreaElement>) => {
     if (e.key === 'Enter' && !e.shiftKey) {
       e.preventDefault();
-      fb.handleCommentSubmit();
+      if (canSend) fb.handleCommentSubmit();
     } else if (e.key === 'Escape') {
       fb.cancelComment();
     }
@@ -180,7 +185,10 @@ export function FeedbackCommentBox({ fb }: { fb: FeedbackState }) {
           value={fb.comment}
           onChange={(e) => fb.setComment(e.target.value)}
           onKeyDown={handleKeyDown}
-          placeholder="What went wrong? (optional)"
+          placeholder="What went wrong?"
+          aria-label="What went wrong?"
+          aria-required="true"
+          required
           className="w-full resize-none border-0 bg-transparent text-sm text-foreground placeholder:text-muted-foreground focus:outline-none"
           autoFocus
           rows={1}
@@ -195,8 +203,9 @@ export function FeedbackCommentBox({ fb }: { fb: FeedbackState }) {
           </button>
           <button
             type="button"
-            className="rounded-md bg-primary px-3 py-1 text-xs text-primary-foreground hover:bg-primary/90 transition-colors disabled:opacity-40"
-            disabled={fb.isSubmitting}
+            className="rounded-md bg-primary px-3 py-1 text-xs text-primary-foreground hover:bg-primary/90 transition-colors disabled:pointer-events-none disabled:opacity-40"
+            disabled={!canSend}
+            aria-disabled={!canSend}
             onClick={fb.handleCommentSubmit}
           >
             {fb.isSubmitting ? 'Sending...' : 'Send'}

From 658a499f2d6a47de9adb10772604e8f8d3b9eeac Mon Sep 17 00:00:00 2001
From: mimran-khan <mohammed_imran.khan@outlook.com>
Date: Thu, 12 Nov 2026 12:32:32 +0530
Subject: [PATCH 2/2] fix: finish interrupt streams so auto-approve can
 complete

An interrupt with no answer text was treated as a dropped stream, so the
run stayed loading and the approval never resumed. A paused interrupt now
ends the stream, and the auto-approve test reports the thread as interrupted.

Signed-off-by: mimran-khan <mohammed_imran.khan@outlook.com>
---
 e2e/hitl/auto-approve.spec.ts           | 17 ++++++++++++++---
 src/frontend/hooks/useStreamingAPI.ts   | 14 ++++++++++++++
 src/frontend/redux/slices/chats.test.ts |  2 +-
 3 files changed, 29 insertions(+), 4 deletions(-)

diff --git a/e2e/hitl/auto-approve.spec.ts b/e2e/hitl/auto-approve.spec.ts
index 3670080d..37ab4657 100644
--- a/e2e/hitl/auto-approve.spec.ts
+++ b/e2e/hitl/auto-approve.spec.ts
@@ -35,6 +35,18 @@ async function makeInterruptStream(
   callCount: { n: number },
   page: import('@playwright/test').Page,
 ): Promise<void> {
+  await page.route('**/api/proxy/agent/threads/*', (route) => {
+    const path = new URL(route.request().url()).pathname;
+    const isThreadRecord = /\/threads\/(?!search$)[^/]+$/.test(path);
+    if (route.request().method() === 'GET' && isThreadRecord) {
+      return route.fulfill({
+        status: 200,
+        contentType: 'application/json',
+        body: JSON.stringify({ status: 'interrupted' }),
+      });
+    }
+    return route.fallback();
+  });
   await page.route('**/api/proxy/agent/v1/stream', (route) => {
     callCount.n++;
     if (callCount.n === 1) {
@@ -78,8 +90,7 @@ test.describe('HITL — auto-approve', () => {
       const chat = new ChatPage(page);
       await chat.expectChatRoute();
 
-      // The response should complete without the interrupt banner ever appearing
-      await chat.waitForAIResponse(15_000);
+      await expect(page.getByText('Done automatically.')).toBeVisible({ timeout: 15_000 });
       await expect(page.getByText('Action Required')).not.toBeVisible();
       await expect(page.getByText('Input Required')).not.toBeVisible();
       expect(callCount.n).toBeGreaterThanOrEqual(2);
@@ -129,7 +140,7 @@ test.describe('HITL — auto-approve', () => {
       const chat = new ChatPage(page);
       await chat.expectChatRoute();
 
-      await chat.waitForAIResponse(15_000);
+      await expect(page.getByText('Done automatically.')).toBeVisible({ timeout: 15_000 });
       await expect(page.getByText('Action Required')).not.toBeVisible();
       expect(callCount.n).toBeGreaterThanOrEqual(2);
     },
diff --git a/src/frontend/hooks/useStreamingAPI.ts b/src/frontend/hooks/useStreamingAPI.ts
index a38d04f7..0caff0e6 100644
--- a/src/frontend/hooks/useStreamingAPI.ts
+++ b/src/frontend/hooks/useStreamingAPI.ts
@@ -985,6 +985,20 @@ export function useStreamingAPI(threadId: string) {
                 dispatch(resolveAllPendingToolCalls({ chatId: threadId }));
               }
               lastSuccessfulConnectionRef.current = Date.now();
+              if (streamEndedWithInterruptRef.current) {
+                dispatch(updateStreamingState({
+                  chatId: threadId,
+                  state: {
+                    isLoading: false,
+                    isConnected: false,
+                    isReconnecting: false,
+                    reconnectAttempt: 0,
+                    streamDroppedMidResponse: false,
+                  },
+                }));
+                finish('success');
+                return;
+              }
               const gotFullResponse = messagesRef.current.length > initialMessageCount + 1;
               if (gotFullResponse && recoveryIntervalRef.current) {
                 clearInterval(recoveryIntervalRef.current);
diff --git a/src/frontend/redux/slices/chats.test.ts b/src/frontend/redux/slices/chats.test.ts
index b0c99538..4cecbc04 100644
--- a/src/frontend/redux/slices/chats.test.ts
+++ b/src/frontend/redux/slices/chats.test.ts
@@ -168,7 +168,7 @@ describe('chats slice — appendMessageToChat', () => {
 
 describe('chats slice — subagent transcript', () => {
   function withSubagentCard() {
-    let s = chatsReducer(initialState(), addChat(makeChat('c1')));
+    const s = chatsReducer(initialState(), addChat(makeChat('c1')));
     const card: TestMessage = {
       type: 'ai',
       content: 'Asking the analyst.',