From eea98f94a27fbfb034940e8773d0e1fd83376dd0 Mon Sep 17 00:00:00 2001 From: VeithMetro Date: Wed, 15 Jul 2026 12:19:10 +0200 Subject: [PATCH 1/3] Do not link common.lib by accident --- Source/deviceinfo/DeviceInfo.vcxproj | 8 ++++---- Source/securityagent/securityagent.vcxproj | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Source/deviceinfo/DeviceInfo.vcxproj b/Source/deviceinfo/DeviceInfo.vcxproj index 73a0110e..130cf989 100644 --- a/Source/deviceinfo/DeviceInfo.vcxproj +++ b/Source/deviceinfo/DeviceInfo.vcxproj @@ -100,7 +100,7 @@ NotUsing Level3 true - DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;_DEBUG;_LIB;%(PreprocessorDefinitions) + DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;_DEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) true pch.h include;$(FrameworkPath);$(ContractsPath);$(WindowsPath);$(WindowsPath)zlib @@ -122,7 +122,7 @@ NotUsing Level3 true - DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions) + DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;_DEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) true pch.h include;$(FrameworkPath);$(ContractsPath);$(WindowsPath);$(WindowsPath)zlib @@ -146,7 +146,7 @@ true true true - DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions) + DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;NDEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) true pch.h include;$(FrameworkPath);$(ContractsPath);$(WindowsPath);$(WindowsPath)zlib @@ -172,7 +172,7 @@ true true true - DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;NDEBUG;_LIB;%(PreprocessorDefinitions) + DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;NDEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) true pch.h include;$(FrameworkPath);$(ContractsPath);$(WindowsPath);$(WindowsPath)zlib diff --git a/Source/securityagent/securityagent.vcxproj b/Source/securityagent/securityagent.vcxproj index 8faad882..851250a2 100644 --- a/Source/securityagent/securityagent.vcxproj +++ b/Source/securityagent/securityagent.vcxproj @@ -100,7 +100,7 @@ NotUsing Level3 true - SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;_DEBUG;_LIB;%(PreprocessorDefinitions) + SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;_DEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) true pch.h $(FrameworkPath);$(WindowsPath);$(WindowsPath)zlib @@ -122,7 +122,7 @@ NotUsing Level3 true - SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions) + SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;_DEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) true pch.h $(FrameworkPath);$(WindowsPath);$(WindowsPath)zlib @@ -146,7 +146,7 @@ true true true - SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions) + SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;NDEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) true pch.h $(FrameworkPath);$(WindowsPath);$(WindowsPath)zlib @@ -172,7 +172,7 @@ true true true - SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;NDEBUG;_LIB;%(PreprocessorDefinitions) + SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;NDEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) true pch.h $(FrameworkPath);$(WindowsPath);$(WindowsPath)zlib From 8f3f38488af1779da549008dcd2c66d6f7bfca18 Mon Sep 17 00:00:00 2001 From: VeithMetro Date: Thu, 16 Jul 2026 10:02:00 +0200 Subject: [PATCH 2/3] Include only what's needed and not plugins.h --- Source/bluetoothaudiosink/Module.h | 2 +- Source/bluetoothaudiosource/Module.h | 2 +- Source/deviceinfo/DeviceInfo.vcxproj | 8 ++++---- Source/deviceinfo/Module.h | 3 ++- Source/securityagent/Module.h | 2 +- Source/securityagent/securityagent.vcxproj | 8 ++++---- 6 files changed, 13 insertions(+), 12 deletions(-) diff --git a/Source/bluetoothaudiosink/Module.h b/Source/bluetoothaudiosink/Module.h index 80d652f9..5037542d 100644 --- a/Source/bluetoothaudiosink/Module.h +++ b/Source/bluetoothaudiosink/Module.h @@ -25,5 +25,5 @@ #include #include -#include +#include #include diff --git a/Source/bluetoothaudiosource/Module.h b/Source/bluetoothaudiosource/Module.h index 16fba8c1..dc9a84b6 100644 --- a/Source/bluetoothaudiosource/Module.h +++ b/Source/bluetoothaudiosource/Module.h @@ -25,5 +25,5 @@ #include #include -#include +#include #include diff --git a/Source/deviceinfo/DeviceInfo.vcxproj b/Source/deviceinfo/DeviceInfo.vcxproj index 130cf989..73a0110e 100644 --- a/Source/deviceinfo/DeviceInfo.vcxproj +++ b/Source/deviceinfo/DeviceInfo.vcxproj @@ -100,7 +100,7 @@ NotUsing Level3 true - DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;_DEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) + DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;_DEBUG;_LIB;%(PreprocessorDefinitions) true pch.h include;$(FrameworkPath);$(ContractsPath);$(WindowsPath);$(WindowsPath)zlib @@ -122,7 +122,7 @@ NotUsing Level3 true - DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;_DEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) + DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions) true pch.h include;$(FrameworkPath);$(ContractsPath);$(WindowsPath);$(WindowsPath)zlib @@ -146,7 +146,7 @@ true true true - DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;NDEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) + DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions) true pch.h include;$(FrameworkPath);$(ContractsPath);$(WindowsPath);$(WindowsPath)zlib @@ -172,7 +172,7 @@ true true true - DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;NDEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) + DEVICEINFO_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;NDEBUG;_LIB;%(PreprocessorDefinitions) true pch.h include;$(FrameworkPath);$(ContractsPath);$(WindowsPath);$(WindowsPath)zlib diff --git a/Source/deviceinfo/Module.h b/Source/deviceinfo/Module.h index 1da1a536..e8037076 100644 --- a/Source/deviceinfo/Module.h +++ b/Source/deviceinfo/Module.h @@ -25,7 +25,8 @@ #include #include -#include +#include +#include #include #if defined(__WINDOWS__) && defined(DEVICEINFO_EXPORTS) diff --git a/Source/securityagent/Module.h b/Source/securityagent/Module.h index 97d91226..bf553c2d 100644 --- a/Source/securityagent/Module.h +++ b/Source/securityagent/Module.h @@ -25,7 +25,7 @@ #include #include -#include +#include #if defined(__WINDOWS__) && defined(SECURITYAGENT_EXPORTS) diff --git a/Source/securityagent/securityagent.vcxproj b/Source/securityagent/securityagent.vcxproj index 851250a2..8faad882 100644 --- a/Source/securityagent/securityagent.vcxproj +++ b/Source/securityagent/securityagent.vcxproj @@ -100,7 +100,7 @@ NotUsing Level3 true - SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;_DEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) + SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;_DEBUG;_LIB;%(PreprocessorDefinitions) true pch.h $(FrameworkPath);$(WindowsPath);$(WindowsPath)zlib @@ -122,7 +122,7 @@ NotUsing Level3 true - SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;_DEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) + SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions) true pch.h $(FrameworkPath);$(WindowsPath);$(WindowsPath)zlib @@ -146,7 +146,7 @@ true true true - SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;NDEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) + SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions) true pch.h $(FrameworkPath);$(WindowsPath);$(WindowsPath)zlib @@ -172,7 +172,7 @@ true true true - SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;NDEBUG;_LIB;THUNDER_NO_COMMON_LIB;%(PreprocessorDefinitions) + SECURITYAGENT_EXPORTS;_CRT_SECURE_NO_WARNINGS;_WINDOWS;NDEBUG;_LIB;%(PreprocessorDefinitions) true pch.h $(FrameworkPath);$(WindowsPath);$(WindowsPath)zlib From 4442c99ba488579965619c29243eb1c5799b7418 Mon Sep 17 00:00:00 2001 From: VeithMetro Date: Thu, 16 Jul 2026 10:18:42 +0200 Subject: [PATCH 3/3] Remove messaging.h from deviceinfo and cryptography as they do not use it --- Source/cryptography/Module.h | 1 - Source/deviceinfo/Module.h | 1 - 2 files changed, 2 deletions(-) diff --git a/Source/cryptography/Module.h b/Source/cryptography/Module.h index 1cf90ad0..40a869ac 100644 --- a/Source/cryptography/Module.h +++ b/Source/cryptography/Module.h @@ -25,7 +25,6 @@ #include #include -#include #include #if defined(__WINDOWS__) diff --git a/Source/deviceinfo/Module.h b/Source/deviceinfo/Module.h index e8037076..5b313428 100644 --- a/Source/deviceinfo/Module.h +++ b/Source/deviceinfo/Module.h @@ -27,7 +27,6 @@ #include #include #include -#include #if defined(__WINDOWS__) && defined(DEVICEINFO_EXPORTS) #undef EXTERNAL