Skip to content

fix: SeriesInstanceUID fix (compatibility with other software) #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
code-lukas wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: SeriesInstanceUID fix (compatibility with other software) #96

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfc48ad
fix: SeriesInstanceUID fix (compatibility with other software)
code-lukas Oct 10, 2023
4553f18
Changing build
FabianHoerst Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rt_utils/ds_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def add_study_and_series_information(ds: FileDataset, series_data):
ds.StudyDescription = getattr(reference_ds, "StudyDescription", "")
ds.SeriesDescription = getattr(reference_ds, "SeriesDescription", "")
ds.StudyInstanceUID = reference_ds.StudyInstanceUID
ds.SeriesInstanceUID = generate_uid() # TODO: find out if random generation is ok
ds.SeriesInstanceUID = reference_ds.SeriesInstanceUID

@hjmjohnson hjmjohnson Dec 6, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe your solution here is correct. The new images should be part of the previous study.

@code-lukas code-lukas Jan 17, 2024

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjmjohnson Thanks for having a look at this! Would you mind reviewing this so it can be merged in a later release?

@hjmjohnson hjmjohnson Jun 6, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@ferdymercury ferdymercury Jun 23, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would violate the DICOM standard, see https://dicom.nema.org/medical/dicom/current/output/chtml/part03/sect_C.8.8.html#sect_C.8.8.1.1

since RTstruct "Modality" tag is "RTSTRUCT", compared to the reference dataset which has "CT" modality, and it is not allowed to mix two modalities in the same series-instance-uid.

@code-lukas if this is the case, could you report this bug to RayStation? They usually reply quickly to bug reports.

fyi @lassoan

ds.StudyID = reference_ds.StudyID
ds.SeriesNumber = "1" # TODO: find out if we can just use 1 (Should be fine since its a new series)

Expand All @@ -98,7 +98,7 @@ def add_patient_information(ds: FileDataset, series_data):

def add_refd_frame_of_ref_sequence(ds: FileDataset, series_data):
refd_frame_of_ref = Dataset()
refd_frame_of_ref.FrameOfReferenceUID = getattr(series_data[0], 'FrameOfReferenceUID', generate_uid())
refd_frame_of_ref.FrameOfReferenceUID = getattr(series_data[0], 'FrameOfReferenceUID', generate_uid())
refd_frame_of_ref.RTReferencedStudySequence = create_frame_of_ref_study_sequence(series_data)

# Add to sequence
Expand Down