Deprecate making __debugInfo() nullable#21984
Open
TimWolla wants to merge 1 commit intophp:masterfrom
Open
Conversation
Returning `null` is already deprecated since PHP 8.5 (3dc962b). Not deprecating a corresponding return type seems like an oversight.
TimWolla
force-pushed
the
debuginfo-return-null-deprecate
branch
from
7b466dd to
fb64cbf
Compare
Member
|
Hmm, so I don't recall if I had looked at this or not at the time - it makes sense, but I wonder if it needs a new RFC (or an entry in the 8.6 deprecations RFC)? |
Member
Author
I'd say it's an obvious follow-up to the existing deprecation. Being able to define a method returns a type, it cannot actually return doesn't make sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning
nullis already deprecated since PHP 8.5 (3dc962b). Not deprecating a corresponding return type seems like an oversight.