feat(config): support multiple memcached servers via OWNCLOUD_MEMCACHED_SERVERS (#517)

* feat(config): support multiple memcached servers via OWNCLOUD_MEMCACHED_SERVERS

The memcached config block hard-coded a single [host, port] pair built
from OWNCLOUD_MEMCACHED_HOST / OWNCLOUD_MEMCACHED_PORT, with no way to
define multiple servers or per-server weights that core's
'memcached_servers' supports.

Add OWNCLOUD_MEMCACHED_SERVERS, a JSON-encoded list of [host, port] or
[host, port, weight] tuples, reusing the json_decode pattern already used
for OWNCLOUD_LOG_CONDITIONS. It overrides the single-server pair when set
and falls back to it when unset or when the JSON is invalid, so existing
deployments are unaffected. Added to v24.04 only, matching the convention
that v20.04/v22.04 are frozen.

The container startup readiness probe (wait-for-it in 15-database.sh)
still targets HOST:PORT only and is intentionally left unchanged.

Closes #489

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>

* fix(memcached): skip startup wait when OWNCLOUD_MEMCACHED_SERVERS is set

The startup wait in 15-database.sh probed OWNCLOUD_MEMCACHED_HOST:PORT
whenever memcached was enabled and exited on timeout. With
OWNCLOUD_MEMCACHED_SERVERS set (and HOST left at its default), the
container could fail to start even though the configured servers are
reachable.

Guard the wait with `&& [[ ${OWNCLOUD_MEMCACHED_SERVERS} == "" ]]`,
mirroring how the redis wait is skipped when OWNCLOUD_REDIS_SEEDS is set.
Also drop the now-inaccurate ENVIRONMENT.md note that described the old
probing behaviour as a caveat of the new variable.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>

---------

Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: DeepDiver1975

CHANGELOG.md

@@ -11,6 +11,9 @@
   * Env variable `OWNCLOUD_LOGIN_POLICY_GROUP_FORBID_MAP` for the
     `loginPolicy.groupLoginPolicy.forbidMap` config key
     [#493](https://github.com/owncloud-docker/base/issues/493)
+  * Env variable `OWNCLOUD_MEMCACHED_SERVERS` to define multiple memcached
+    servers (and optional per-server weights)
+    [#489](https://github.com/owncloud-docker/base/issues/489)
 
 ## 2026-07-06
 

ENVIRONMENT.md

@@ -227,6 +227,8 @@
   Define connection options for memcached (see [documentation](https://doc.owncloud.com/server/latest/admin_manual/configuration/server/config_sample_php_parameters.html#define-connection-options-for-memcached)).
 - `OWNCLOUD_MEMCACHED_PORT=11211` \
   Defines the ports for memcached (see [documentation](https://doc.owncloud.com/server/latest/admin_manual/configuration/server/config_sample_php_parameters.html#define-server-details-for-memcached-servers-to-use-for-memory-caching)).
+- `OWNCLOUD_MEMCACHED_SERVERS=` \
+  Define multiple memcached servers as a JSON-encoded list of `[host, port]` or `[host, port, weight]` tuples, e.g. `[["mem1",11211,33],["mem2",11211]]`. Overrides the single-server `OWNCLOUD_MEMCACHED_HOST`/`OWNCLOUD_MEMCACHED_PORT` pair when set (see [documentation](https://doc.owncloud.com/server/latest/admin_manual/configuration/server/config_sample_php_parameters.html#define-server-details-for-memcached-servers-to-use-for-memory-caching)).
 - `OWNCLOUD_MEMCACHED_STARTUP_TIMEOUT=180` \
   Time to wait for a successful connection to the memcached service on container startup.
 - `OWNCLOUD_MEMCACHE_LOCAL=${OWNCLOUD_CACHING_CLASS:-\\OC\\Memcache\\APCu}` \

v24.04/overlay/etc/owncloud.d/15-database.sh

@@ -31,7 +31,7 @@ case ${OWNCLOUD_DB_TYPE} in
   ;;
 esac
 
-if [[ ${OWNCLOUD_MEMCACHED_ENABLED} == "true" ]]; then
+if [[ ${OWNCLOUD_MEMCACHED_ENABLED} == "true" ]] && [[ ${OWNCLOUD_MEMCACHED_SERVERS} == "" ]]; then
   echo "Waiting for Memcached..."
   wait_error=false
   wait-for-it -t "${OWNCLOUD_MEMCACHED_STARTUP_TIMEOUT}" "${OWNCLOUD_MEMCACHED_HOST}":"${OWNCLOUD_MEMCACHED_PORT}" || wait_error=true

v24.04/overlay/etc/templates/config.php

@@ -906,16 +906,30 @@ function getConfigFromEnv() {
 
       break;
     case getenv('OWNCLOUD_MEMCACHED_ENABLED') && getenv('OWNCLOUD_MEMCACHED_ENABLED') === 'true':
+      // 'memcached_servers' is a list of [host, port] or [host, port, weight]
+      // tuples. The flat env-var idioms cannot express multiple servers or a
+      // weight, so multiple servers are passed as a JSON-encoded array, e.g.:
+      //   OWNCLOUD_MEMCACHED_SERVERS='[["mem1",11211,33],["mem2",11211]]'
+      // When unset, fall back to the single OWNCLOUD_MEMCACHED_HOST/_PORT pair.
+      $memcachedServers = [
+        [
+          getenv('OWNCLOUD_MEMCACHED_HOST'),
+          getenv('OWNCLOUD_MEMCACHED_PORT'),
+        ],
+      ];
+
+      if (getenv('OWNCLOUD_MEMCACHED_SERVERS') != '') {
+        $servers = json_decode(getenv('OWNCLOUD_MEMCACHED_SERVERS'), true);
+        if (is_array($servers)) {
+          $memcachedServers = $servers;
+        }
+      }
+
       $config = array_merge_recursive($config, [
         'memcache.distributed' => '\OC\Memcache\Memcached',
         'memcache.locking' => '\OC\Memcache\Memcached',
 
-        'memcached_servers' => [
-          [
-            getenv('OWNCLOUD_MEMCACHED_HOST'),
-            getenv('OWNCLOUD_MEMCACHED_PORT'),
-          ],
-        ],
+        'memcached_servers' => $memcachedServers,
       ]);
 
       if (getenv('OWNCLOUD_MEMCACHED_OPTIONS') != '') {