diff --git a/plugins/module_utils/openshift_adm_prune_images.py b/plugins/module_utils/openshift_adm_prune_images.py index 768c359b..3be36bbc 100644 --- a/plugins/module_utils/openshift_adm_prune_images.py +++ b/plugins/module_utils/openshift_adm_prune_images.py @@ -9,7 +9,6 @@ from ansible.module_utils._text import to_native from ansible.module_utils.parsing.convert_bool import boolean -from ansible.module_utils.six import iteritems from ansible_collections.community.okd.plugins.module_utils.openshift_common import ( AnsibleOpenshiftModule, @@ -106,7 +105,7 @@ def __init__(self, **kwargs): def list_objects(self): result = {} - for kind, version in iteritems(ApiConfiguration): + for kind, version in ApiConfiguration.items(): namespace = None if self.params.get("namespace") and kind.lower() == "imagestream": namespace = self.params.get("namespace") diff --git a/plugins/module_utils/openshift_images_common.py b/plugins/module_utils/openshift_images_common.py index 8978a93b..fa7e3624 100644 --- a/plugins/module_utils/openshift_images_common.py +++ b/plugins/module_utils/openshift_images_common.py @@ -8,7 +8,6 @@ from ansible_collections.community.okd.plugins.module_utils.openshift_docker_image import ( parse_docker_image_ref, ) -from ansible.module_utils.six import iteritems def get_image_blobs(image): @@ -119,7 +118,7 @@ def analyze_refs_pod_creators(self, resources): "CronJob", ) - for k, objects in iteritems(resources): + for k, objects in resources.items(): if k not in keys: continue for obj in objects: @@ -222,7 +221,7 @@ def _parse_image_stream_tag_name(name): def analyze_refs_from_build_strategy(self, resources): # Json Path is always spec.strategy keys = ("BuildConfig", "Build") - for k, objects in iteritems(resources): + for k, objects in resources.items(): if k not in keys: continue for obj in objects: diff --git a/plugins/module_utils/openshift_import_image.py b/plugins/module_utils/openshift_import_image.py index c9953d76..635d70e3 100644 --- a/plugins/module_utils/openshift_import_image.py +++ b/plugins/module_utils/openshift_import_image.py @@ -7,7 +7,6 @@ import copy from ansible.module_utils.parsing.convert_bool import boolean -from ansible.module_utils.six import string_types from ansible_collections.community.okd.plugins.module_utils.openshift_common import ( AnsibleOpenshiftModule, @@ -370,7 +369,7 @@ def parse_image_reference(self, image_ref): def execute_module(self): names = [] name = self.params.get("name") - if isinstance(name, string_types): + if isinstance(name, str): names.append(name) elif isinstance(name, list): names = name diff --git a/plugins/module_utils/openshift_ldap.py b/plugins/module_utils/openshift_ldap.py index cb197748..38ccef14 100644 --- a/plugins/module_utils/openshift_ldap.py +++ b/plugins/module_utils/openshift_ldap.py @@ -12,7 +12,6 @@ import copy from ansible.module_utils.parsing.convert_bool import boolean -from ansible.module_utils.six import iteritems try: import ldap @@ -46,7 +45,7 @@ def validate_ldap_sync_config(config): return "could not read ca file: {0}.".format(ca_file) nameMapping = config.get("groupUIDNameMapping", {}) - for k, v in iteritems(nameMapping): + for k, v in nameMapping.items(): if len(k) == 0 or len(v) == 0: return "groupUIDNameMapping has empty key or value" diff --git a/tests/sanity/ignore-2.20.txt b/tests/sanity/ignore-2.20.txt new file mode 100644 index 00000000..20ecba7f --- /dev/null +++ b/tests/sanity/ignore-2.20.txt @@ -0,0 +1,3 @@ +plugins/modules/k8s.py validate-modules:parameter-type-not-in-doc +plugins/modules/k8s.py validate-modules:return-syntax-error +plugins/modules/openshift_process.py validate-modules:parameter-type-not-in-doc diff --git a/tests/sanity/ignore-2.21.txt b/tests/sanity/ignore-2.21.txt new file mode 100644 index 00000000..0cf940f3 --- /dev/null +++ b/tests/sanity/ignore-2.21.txt @@ -0,0 +1,5 @@ +plugins/modules/k8s.py validate-modules:parameter-type-not-in-doc +plugins/modules/k8s.py validate-modules:return-syntax-error +plugins/modules/k8s.py validate-modules:bad-return-value-key +plugins/modules/openshift_process.py validate-modules:parameter-type-not-in-doc +plugins/modules/openshift_process.py validate-modules:bad-return-value-key