MGMT-19930: upgrade the pgx to v5

It is beneficial because compared to v4 (previously used) v5 has optimized memory usage.
pgx comes as an indirect dependency from gorm.io/driver/postgres. So this task involves upgrading the postgres driver too.

Author: andrej1991

cmd/main.go

@@ -802,8 +802,7 @@ func setupServerForIPXE(serverInfo *servers.ServerInfo, h http.Handler) {
 }
 
 func setupDB(log logrus.FieldLogger) *gorm.DB {
-	dbConnectionStr := fmt.Sprintf("host=%s port=%s user=%s database=%s password=%s sslmode=disable",
-		Options.DBConfig.Host, Options.DBConfig.Port, Options.DBConfig.User, Options.DBConfig.Name, Options.DBConfig.Pass)
+	dbConnectionStr := Options.DBConfig.LibpqDSN()
 	var db *gorm.DB
 	var err error
 	// Tries to open a db connection every 2 seconds

go.mod

@@ -82,8 +82,8 @@ require (
 	golang.org/x/sys v0.38.0
 	gopkg.in/ini.v1 v1.67.0
 	gopkg.in/yaml.v2 v2.4.0
-	gorm.io/driver/postgres v1.3.5
-	gorm.io/gorm v1.25.8
+	gorm.io/driver/postgres v1.6.0
+	gorm.io/gorm v1.25.10
 	k8s.io/api v0.34.2
 	k8s.io/apiextensions-apiserver v0.29.5
 	k8s.io/apimachinery v0.34.2
@@ -122,9 +122,9 @@ require (
 	github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674 // indirect
 	github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79 // indirect
 	github.com/grpc-ecosystem/grpc-gateway/v2 v2.18.1 // indirect
-	github.com/jackc/chunkreader/v2 v2.0.1 // indirect
 	github.com/jackc/pgio v1.0.0 // indirect
-	github.com/jackc/pgproto3/v2 v2.3.3 // indirect
+	github.com/jackc/pgx/v5 v5.6.0 // indirect
+	github.com/jackc/puddle/v2 v2.2.2 // indirect
 	github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de // indirect
 	github.com/lufia/plan9stats v0.0.0-20211012122336-39d0f177ccd0 // indirect
 	github.com/magiconair/properties v1.8.7 // indirect
@@ -201,11 +201,9 @@ require (
 	github.com/imdario/mergo v0.3.16 // indirect
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
 	github.com/itchyny/timefmt-go v0.1.3 // indirect
-	github.com/jackc/pgconn v1.14.3 // indirect
 	github.com/jackc/pgpassfile v1.0.0 // indirect
-	github.com/jackc/pgservicefile v0.0.0-20221227161230-091c0ba34f0a // indirect
+	github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 // indirect
 	github.com/jackc/pgtype v1.14.4 // indirect
-	github.com/jackc/pgx/v4 v4.18.2 // indirect
 	github.com/jinzhu/inflection v1.0.0 // indirect
 	github.com/jinzhu/now v1.1.5 // indirect
 	github.com/jmespath/go-jmespath v0.4.1-0.20220621161143-b0104c826a24 // indirect
@@ -273,7 +271,6 @@ require (
 
 replace (
 	github.com/google/gnostic-models => github.com/google/gnostic-models v0.6.8
-	github.com/jackc/pgx/v4 => github.com/jackc/pgx/v4 v4.18.3
 	github.com/metal3-io/baremetal-operator => github.com/openshift/baremetal-operator v0.0.0-20231019133159-8643f32fea3e
 	github.com/metal3-io/baremetal-operator/apis => github.com/openshift/baremetal-operator/apis v0.0.0-20231019133159-8643f32fea3e
 	github.com/metal3-io/baremetal-operator/pkg/hardwareutils => github.com/openshift/baremetal-operator/pkg/hardwareutils v0.0.0-20231019133159-8643f32fea3e

go.sum

@@ -11,6 +11,7 @@ import (
 
 	"github.com/google/uuid"
 	. "github.com/onsi/gomega"
+	dbpkg "github.com/openshift/assisted-service/pkg/db"
 	"gorm.io/driver/postgres"
 	"gorm.io/gorm"
 	"gorm.io/gorm/logger"
@@ -337,11 +338,7 @@ func DeleteTestDB(db *gorm.DB, dbName string) {
 
 func getDBDSN(dbName string) string {
 	host, port := getDBContext().GetHostPort()
-	dsn := fmt.Sprintf("host=%s port=%s user=postgres password=admin sslmode=disable", host, port)
-	if dbName != "" {
-		dsn = dsn + fmt.Sprintf(" database=%s", dbName)
-	}
-	return dsn
+	return dbpkg.LibpqDSN(host, port, "postgres", "admin", dbName)
 }
 
 func openTestDB(dbName string) (*gorm.DB, error) {

internal/common/common_unitest_db.go

@@ -1,9 +1,33 @@
 package db
 
+import "fmt"
+import "strings"
+
 type Config struct {
 	Host string `envconfig:"DB_HOST"`
 	Port string `envconfig:"DB_PORT"`
 	User string `envconfig:"DB_USER"`
 	Pass string `envconfig:"DB_PASS"`
 	Name string `envconfig:"DB_NAME"`
 }
+
+func escapeConninfoValue(v string) string {
+	replacer := strings.NewReplacer(`\`, `\\`, `'`, `\'`)
+	return "'" + replacer.Replace(v) + "'"
+}
+
+// LibpqDSN returns a PostgreSQL libpq keyword connection string for GORM/pgx.
+// client_encoding=UTF8 is always set so pgx v5 simple-query paths (used by some GORM APIs) work regardless of server defaults.
+func LibpqDSN(host, port, user, password, database string) string {
+	s := fmt.Sprintf("host=%s port=%s user=%s password=%s sslmode=disable client_encoding=UTF8",
+		host, port, escapeConninfoValue(user), escapeConninfoValue(password))
+	if database != "" {
+		s += fmt.Sprintf(" database=%s", escapeConninfoValue(database))
+	}
+	return s
+}
+
+// LibpqDSN builds a libpq DSN from c using the same rules as the package function.
+func (c Config) LibpqDSN() string {
+	return LibpqDSN(c.Host, c.Port, c.User, c.Pass, c.Name)
+}

pkg/db/db.go

@@ -3,7 +3,6 @@ package kubeapi
 import (
 	"context"
 	"encoding/json"
-	"fmt"
 	"net/url"
 	"os"
 	"testing"
@@ -19,6 +18,7 @@ import (
 	"github.com/openshift/assisted-service/client"
 	"github.com/openshift/assisted-service/models"
 	"github.com/openshift/assisted-service/pkg/auth"
+	dbpkg "github.com/openshift/assisted-service/pkg/db"
 	"github.com/openshift/assisted-service/subsystem/utils_test"
 	hivev1 "github.com/openshift/hive/apis/hive/v1"
 	"github.com/sirupsen/logrus"
@@ -108,8 +108,7 @@ func init() {
 	userClientCfg := clientcfg(auth.UserAuthHeaderWriter("bearer " + Options.TestToken))
 	agentClientCfg := clientcfg(auth.AgentAuthHeaderWriter(utils_test.FakePS))
 
-	db, err := gorm.Open(postgres.Open(fmt.Sprintf("host=%s port=%s user=admin database=installer password=admin sslmode=disable",
-		Options.DBHost, Options.DBPort)), &gorm.Config{})
+	db, err := gorm.Open(postgres.Open(dbpkg.LibpqDSN(Options.DBHost, Options.DBPort, "admin", "admin", "installer")), &gorm.Config{})
 	if err != nil {
 		logrus.Fatal("Fail to connect to DB, ", err)
 	}

subsystem/kubeapi/kubeapi_suite_test.go

@@ -3,7 +3,6 @@ package subsystem
 import (
 	"context"
 	"encoding/json"
-	"fmt"
 	"net/url"
 	"os"
 	"testing"
@@ -20,6 +19,7 @@ import (
 	"github.com/openshift/assisted-service/client/versions"
 	"github.com/openshift/assisted-service/models"
 	"github.com/openshift/assisted-service/pkg/auth"
+	dbpkg "github.com/openshift/assisted-service/pkg/db"
 	"github.com/openshift/assisted-service/subsystem/utils_test"
 	hivev1 "github.com/openshift/hive/apis/hive/v1"
 	"github.com/sirupsen/logrus"
@@ -112,8 +112,7 @@ func init() {
 		log.Fatal(err.Error())
 	}
 
-	db, err := gorm.Open(postgres.Open(fmt.Sprintf("host=%s port=%s user=admin database=installer password=admin sslmode=disable",
-		Options.DBHost, Options.DBPort)), &gorm.Config{})
+	db, err := gorm.Open(postgres.Open(dbpkg.LibpqDSN(Options.DBHost, Options.DBPort, "admin", "admin", "installer")), &gorm.Config{})
 	if err != nil {
 		logrus.Fatal("Fail to connect to DB, ", err)
 	}