Only try to limit search to spaces if there's a space id to limit to

[aduffeck]

This enables clients to drop the /remote.php prefix of search requests.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 4 complexity · 0 duplication

Metric	Results
Complexity	4
Duplication	0

View in Codacy

🟢 Coverage 0.00% diff coverage · -0.01% coverage variation

Metric	Results
Coverage variation	✅ -0.01% coverage variation (-1.00%)
Diff coverage	✅ 0.00% diff coverage

View coverage diff in Codacy

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (cff5649)	81329	18675	22.96%
Head commit (c445f1f)	81333 (+4)	18664 (-11)	22.95% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#2834)	14	0	0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[ScharfViktor]

we run tests with remote.php by default now. lets run it again after merging #2826

[ScharfViktor]

some tests still broken:

REPORT request without remote.php returns empty result (only with dav/spaces path)

• apiContract/sharesReport.feature:43
• apiContract/sharesReport.feature:84
• apiContract/sharesReport.feature:150
• apiContract/sharesReport.feature:180
• apiContract/spacesReport.feature:16
• apiContract/spacesReport.feature:35
• apiContract/spacesReport.feature:55
• apiContract/spacesReport.feature:74
• apiContract/spacesSharesReport.feature:46
• apiContract/spacesSharesReport.feature:77
• apiSearch1/search.feature:176

with remote.php

without remote.php

[ScharfViktor]

found why apiSearch1/search.feature:176 is failed

if we send REPORT https://localhost:9200/dav/spaces -> shouldn't we get <d:href>/remote.php/dav/spaces/a26d06e4-d45e-4878-8b0a-26125d9046db$3eec4f61-ee6c-4e78-8c52-734fe106c5af</d:href> (with remore.php)?