Skip to content

Return an assessment for explicit Guardian reviews - #62846

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/54689dc043d77f940e10d29842308340f6937980
Nov 20, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/54689dc043d77f940e10d29842308340f6937980

Conversation

@copyberry

@copyberry copyberry Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Return an assessment for explicit Guardian reviews

Why

An explicit thread/guardianReview request could return a null assessment when live execution would skip approval, leaving callers without a verdict on the recorded action.

What changed

Require assessment on every successful thread/guardianReview response. Review eligible recorded calls even when a command is allowlisted, an MCP tool is configured for automatic approval or has a remembered approval, or the policy disables permission requests. The review runs without executing the call or granting permissions.

Include the MCP server's owning environment permissions in the review context, matching live review.

Testing

Cover allowlisted commands, permission requests with prompting disabled, and automatically approved MCP tools. Compare live and recorded MCP review input for a server whose owning environment has denied paths.

## Why

An explicit `thread/guardianReview` request could return a null assessment when live execution would skip approval, leaving callers without a verdict on the recorded action.

## What changed

Require `assessment` on every successful `thread/guardianReview` response. Review eligible recorded calls even when a command is allowlisted, an MCP tool is configured for automatic approval or has a remembered approval, or the policy disables permission requests. The review runs without executing the call or granting permissions.

Include the MCP server's owning environment permissions in the review context, matching live review.

## Testing

Cover allowlisted commands, permission requests with prompting disabled, and automatically approved MCP tools. Compare live and recorded MCP review input for a server whose owning environment has denied paths.

GitOrigin-RevId: 54689dc043d77f940e10d29842308340f6937980
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/54689dc043d77f940e10d29842308340f6937980 branch from 1b94e41 to 9735367 Compare November 20, 2026 21:58
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor
Codex Review Summary: 🔄 Running

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-11-20T21:58:38.241882Z 1b94e41 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot merged commit 9735367 into main Nov 20, 2026
9 of 24 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/54689dc043d77f940e10d29842308340f6937980 branch November 20, 2026 21:58
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 20, 2026
@rdouma
rdouma deployed to issue-triage November 20, 2026 22:01 — with GitHub Actions Active
@rdouma
rdouma deployed to issue-triage November 20, 2026 22:01 — with GitHub Actions Active
@rdouma
rdouma deployed to issue-triage November 20, 2026 22:01 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 9735367e Deployed Nov 20, 2026 by rdouma via Identify potential duplicates (all issues) #64717
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants