diff --git a/.github/PULL_REQUEST_TEMPLATE/comment_documentation_change.md b/.github/PULL_REQUEST_TEMPLATE/comment_documentation_change.md new file mode 100644 index 0000000..4c5537c --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/comment_documentation_change.md @@ -0,0 +1,50 @@ +--- +name: Comment / Documentation Change +about: Changes limited to comments, README, docstrings, or other documentation +labels: documentation +--- + +## Description of Change + + + +## Linked Issue + + +Closes # + +## Areas of Expertise Touched + + +- [ ] ASTRO +- [ ] CI/CD +- [ ] COSMOS +- [ ] Cybersecurity +- [ ] Docker +- [ ] EDS +- [ ] Git +- [ ] PSPs +- [ ] SBN +- [ ] SMP +- [ ] Tables +- [ ] TSN +- [ ] Unit Tests +- [ ] Other + +--- + +## Author Checklist + +- [ ] Linked GitHub issue is referenced above/linked to this PR +- [ ] Documentation generation workflow ran successfully on this branch +- [ ] Changes are limited to documentation/comments (no code behavior changes) + +--- + +## Reviewer Checklist + +- [ ] Documentation is clear, accurate, and complete +- [ ] Spelling and grammar reviewed +- [ ] Any links in the documentation have been verified to work +- [ ] Documentation generation workflow output looks correct +- [ ] Appropriate Expert areas have been reviewed \ No newline at end of file diff --git a/.github/PULL_REQUEST_TEMPLATE/tools_code_change.md b/.github/PULL_REQUEST_TEMPLATE/tools_code_change.md new file mode 100644 index 0000000..00d2f1b --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/tools_code_change.md @@ -0,0 +1,67 @@ +--- +name: Tools Repository Change +about: Changes to ground-side tools +labels: tools +--- + +## Description of Change + + + +## Linked Issue + +Closes # + +## Testing Evidence + + + +## Areas of Expertise Touched + +- [ ] ASTRO +- [ ] CI/CD +- [ ] COSMOS +- [ ] Cybersecurity +- [ ] Docker +- [ ] EDS +- [ ] Git +- [ ] PSPs +- [ ] SBN +- [ ] SMP +- [ ] Tables +- [ ] TSN +- [ ] Unit Tests +- [ ] Other + +--- + +## Author Checklist + +- [ ] Linked GitHub issue is referenced above +- [ ] Tool has been tested locally and works as intended +- [ ] Tests updated/added to cover the changes +- [ ] All CI workflows ran and passed +- [ ] Testing evidence is included above +- [ ] Self-review of the diff completed + +--- + +## Reviewer Checklist + +- [ ] Code logic is correct and matches the stated intent +- [ ] Code is readable, maintainable, and follows project conventions +- [ ] Tests are meaningful and adequately cover the changes +- [ ] Testing evidence reviewed and acceptable +- [ ] **The change has been exercised by the tests** (not just that tests pass — the new/changed code paths are actually covered) +- [ ] **Reviewer has independently verified the change behaves as described** (e.g., by running the tool locally, reviewing CI output in detail, or performing additional ad-hoc testing as warranted) +- [ ] Error handling is appropriate +- [ ] Appropriate Expert areas have been reviewed + +### Reviewer Testing Notes + + \ No newline at end of file diff --git a/.github/PULL_REQUEST_TEMPLATE/workflows_change.md b/.github/PULL_REQUEST_TEMPLATE/workflows_change.md new file mode 100644 index 0000000..8fe91cb --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/workflows_change.md @@ -0,0 +1,50 @@ +--- +name: Workflows Change +about: Changes to files under .github/workflows/ +labels: ci/workflows +--- + +## Description of Change + + + +## Linked Issue + +Closes # + +## Areas of Expertise Touched + +- [ ] ASTRO +- [ ] CI/CD +- [ ] COSMOS +- [ ] Cybersecurity +- [ ] Docker +- [ ] EDS +- [ ] Git +- [ ] PSPs +- [ ] SBN +- [ ] SMP +- [ ] Tables +- [ ] TSN +- [ ] Unit Tests +- [ ] Other + +--- + +## Author Checklist + +- [ ] Linked GitHub issue is referenced above +- [ ] Workflow changes were tested on a branch/fork before submitting this PR +- [ ] All workflows ran successfully on this branch + +--- + +## Reviewer Checklist + +- [ ] Workflow logic is correct and achieves the stated goal +- [ ] Third-party actions are from trusted sources and pinned to a specific SHA/tag +- [ ] Secrets are handled appropriately (no secrets exposed in logs, least-privilege usage) +- [ ] Workflow permissions follow the principle of least privilege +- [ ] Changes do not break or bypass existing branch protection rules +- [ ] All workflow runs on this PR completed successfully +- [ ] Appropriate Expert areas have been reviewed \ No newline at end of file