-
Notifications
You must be signed in to change notification settings - Fork 40
feat: adding webview support #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gmegidish
wants to merge
22
commits into
main
Choose a base branch
from
feat-adding-webview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
de0f07c
feat(protocol): add WebViewInfo, WebViewBridge, and WebViewSession types
gmegidish a2c68f3
feat(query-engine): add webview strategy kind
gmegidish 4ba901a
feat(core): add WebViewLocator, Page stub, and screen.getByWebView()
gmegidish 8ed5a83
feat(core): implement Page class and WebLocator stub
gmegidish afe7eaa
feat(core): Playwright-compatible DOM selector engine and WebLocator …
gmegidish 6029b75
feat(core): add PageAssertions and WebLocatorAssertions to expect()
gmegidish 09684e4
refactor(expect): WebLocatorAssertions extends LocatorAssertions
gmegidish 6ef547d
style(expect): restore multi-line inline functions for readability
gmegidish 1928a59
feat(tests): add unit tests for Page and WebLocator (step 7)
gmegidish 571a2e5
Merge origin/main into feat-adding-webview; thread stepFn through web…
gmegidish 35ebda1
feat(webview): mobilecli webView bridge, page goBack/goForward, iOS p…
gmegidish 71b4f4c
refactor(core): share step/eval helpers and drop dead WebViewSession …
gmegidish 0e08b8b
refactor(core): dedupe assertion helpers, share webview test fakes, t…
gmegidish a3983e3
fix test so it uses local mobilewright without npx
gmegidish 02bde8b
Merge remote-tracking branch 'origin/main' into feat-adding-webview
gmegidish 71c1c14
fix(core): resolve webview locators uniquely, reset regex state, hono…
gmegidish f3b1882
fix(core): scope chained web locators and reset regex state in waitFo…
gmegidish 7798f42
fix(core): assert element exists before web locator actions instead o…
gmegidish 19b32fb
test(core): add regression tests for webview resolution, regex state,…
gmegidish d876764
upgrade mobilecli
gmegidish 3b522c1
test(core): cover webview locator nth/first, chaining, and page() err…
gmegidish c95aa9f
fixed tests
gmegidish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.