From d5db8fa438f573351448294cb0a2c5b821664d72 Mon Sep 17 00:00:00 2001 From: "xianliang.li" Date: Tue, 18 Aug 2026 20:25:55 +0800 Subject: [PATCH] enhance: bump knowhere to v3.0.8 Move the knowhere pin from 6a3b7df1 to the v3.0.8 tag (main at d85f7080, zilliztech/knowhere#1780), which bumps the cardinal references to v3.0.5 (v2) and v2.5.110 (v1). Note this range also brings in #1673 "support nullable external id mapping", which the previous pin deliberately excluded. Signed-off-by: xianliang.li --- internal/core/thirdparty/knowhere/CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/core/thirdparty/knowhere/CMakeLists.txt b/internal/core/thirdparty/knowhere/CMakeLists.txt index a63bee275c8..c43ac58a009 100644 --- a/internal/core/thirdparty/knowhere/CMakeLists.txt +++ b/internal/core/thirdparty/knowhere/CMakeLists.txt @@ -14,9 +14,9 @@ # Update KNOWHERE_VERSION for the first occurrence milvus_add_pkg_config("knowhere") set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "") -# Pins the short zilliztech/knowhere#1761 commit without nullable ID mapping. -# It retains the COSINE/IP CalcDistByIDs fix for fully cached DiskANN vectors. -set( KNOWHERE_VERSION 6a3b7df1 ) +# Pins zilliztech/knowhere v3.0.8, which bumps the cardinal references +# to v3.0.5 (v2) and v2.5.110 (v1). +set( KNOWHERE_VERSION v3.0.8 ) set( GIT_REPOSITORY "https://github.com/zilliztech/knowhere.git") message(STATUS "Knowhere repo: ${GIT_REPOSITORY}")