Agents: End up with empty new session if I stop session while it's asking for permission

[bamurtaugh]

• Create new session
• Ask agent to count how many files are in my repo
• I get a permission request
• Stop session during permission request
• ❓ Session didn't disappear from session list (even though other sessions disappeared completely from the list if I stopped them before their first turn completed), and I have empty session content
  • I don't seem to repro if I stop a session with existing content in it

[osortega]

@bamurtaugh I believe this is the same behavior for CLI sessions in core, are we thinking we want to delete the session from the list if it's the first request?

[bamurtaugh]

@osortega I think I'm now encountering a broader issue with stopping and archiving sessions (whether or not they're asking for permission):

• Kick off a new session

• Stop it early while it's still working on its first message

• Use the checkmark to mark it as done. ❓ The session output is cleared, but the session remains in the list. The chat input box also updates in an unexpected way (i.e. I get a chat tip, I see "Local" target dropdown)

• Reload Agents app
• That stopped message is at first not in list
• ❓ After a few seconds, message returns to the list. If I select it, my original message is restored

• I can now fully mark it as done successfully

[osortega]

There are sooo many things going wrong here and I think this is a regression. We definitely need to fix this before end of week.
@sandy081 @DonJayamanne any ideas what could've caused this regression?

[DonJayamanne]

Can your confirm this is a regression,

I believe this has been around, as that's how sessions work.
Initially the Uri is untitled, so while first session is running, it will have untitled Uri.
Only at the end of the turn will it get swapped with the real session Uri.
That's been around for a while and no changes have been in that area

There are sooo many things going wrong here and I think this is a regression. We definitely need to fix this before end of week.

I would suggest first confirming that this is a regression,

[osortega]

The regression was only that we don't properly archive the session, so when you stop the session and try to archive it we will lose the chat session content and leave it in the list.

Now for the case where we stop the session before we commit and swap not sure what we can do. The ref for the chat model will be disposed once you switch away from the session and we won't be able to recover since that session is unknown AFAIK.
@DonJayamanne does the provider keep a reference to that chat session even if it never swaps?