regression URL parsing in PR #231

[bmerkle]

Hej, @KRRT7 @gvanrossum

Seems we have a regression with the PR #231
#231
02ca2d2

My .env file contains AZURE_OPENAI_ENDPOINT and AZURE_OPENAI_ENDPOINT_EMBEDDING which includes the api version after ?
Note that this is default, how you get it from the foundry UI when creating new deployments, to this format should be the default in .env files and it should also work out of the box. (as most users will use this format)

make test now fails with my .env files containing ? and api version

we have two problems:

1. AsyncAzureOpenAI then appends its own /openai/deployments/gpt-4o/chat/completions, resulting in a doubled path → 404.
2. The test_online.py test uses create_async_openai_client (a different code path in utils.py), whereas the failing test goes through create_chat_model → _make_azure_provider → AzureProvider(openai_client=AsyncAzureOpenAI(...)).

[KRRT7]

Hi @bmerkle I'm using https://ai.azure.com and was not having the same behavior, what version of the python SDK are you on?

[bmerkle]

I am on the versions, defined in the project.toml.
another thing is that .\make format yields changes (which is strange)

just creating a PR for this issue.

[KRRT7]

Dug into this — the root cause is in parse_azure_endpoint (src/typeagent/aitools/utils.py).

PR #231 strips the query string (?api-version=...) but doesn't strip the /openai/deployments/{name} path that Azure Foundry includes in its default endpoint URLs. So when the endpoint from .env looks like:

https://foo.openai.azure.com/openai/deployments/gpt-4o?api-version=2024-06-01

After the split("?") fix, parse_azure_endpoint returns:

https://foo.openai.azure.com/openai/deployments/gpt-4o

Then AsyncAzureOpenAI.__init__ appends /openai to that (since no azure_deployment kwarg is passed), producing:

https://foo.openai.azure.com/openai/deployments/gpt-4o/openai/chat/completions

→ 404.

Fix would be to also strip the /openai/deployments/{name} path (and trailing /openai) in parse_azure_endpoint after stripping the query string:

clean_endpoint = azure_endpoint.split("?", 1)[0]
clean_endpoint = re.sub(r"/openai/deployments/[^/]+$", "", clean_endpoint)
clean_endpoint = re.sub(r"/openai$", "", clean_endpoint)

Re: test_online.py working — it likely takes the non-Azure AsyncOpenAI branch when OPENAI_API_KEY is set, while the actual app path goes through create_chat_model → _make_azure_provider which hits the broken Azure path.

[bmerkle]

and we have format changes which are not checked in in main

fresh

git pull 
make

results in

merklbe1@H69LST3:~/typeagent-py (main *=)$ git status
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   src/typeagent/knowpro/conversation_base.py
        modified:   src/typeagent/knowpro/knowledge.py
        modified:   src/typeagent/storage/memory/semrefindex.py
        modified:   tests/benchmarks/test_benchmark_vectorbase.py
        modified:   tests/test_knowledge.py
        modified:   tests/test_semrefindex.py
        modified:   tools/query.py
        modified:   tools/release.py

[KRRT7]

this might be from a PR I made against guido's fork which got merged in and bypassed checks entirely.

[bmerkle]

never mind, i have a PR ready now to fix the two problems.
@KRRT7 can you review #239 ?