Skip to content

Commit 7795074

Browse files
committed
fix: address code review feedback
- Fix filename mismatch in YAML comment (line 7) - Add config.model to check_tests node for consistency - Add model field to generate_review node - Remove pip install osop from README (these are declarative docs, not executable) - Add note that OSOP files are declarative descriptions - Fix GitHub links to correct repo URLs
1 parent ff689d0 commit 7795074

File tree

2 files changed

+12
-17
lines changed

2 files changed

+12
-17
lines changed
Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# OSOP Workflow Examples for Semantic Kernel
22

3-
[OSOP](https://github.com/osopcloud/osop-spec) (Open Standard for Orchestration Protocols) is a portable YAML format for describing AI workflows — think OpenAPI, but for agent orchestration.
3+
[OSOP](https://github.com/Archie0125/osop-spec) (Open Standard Operating Procedures) is a portable YAML format for describing AI workflows — think OpenAPI, but for agent orchestration.
4+
5+
> **Note:** OSOP files are declarative workflow descriptions, not executable code. They document orchestration patterns in a framework-agnostic format.
46
57
## What's Here
68

@@ -15,18 +17,7 @@ Semantic Kernel provides powerful AI orchestration with plugins, planners, and a
1517
- **Documented** — readable YAML that non-developers can understand
1618
- **Validated** — check workflow structure before execution
1719
- **Ported** — same workflow definition works across Semantic Kernel, LangChain, AutoGen, etc.
18-
- **Visualized** — render the workflow as a graph in the [OSOP Editor](https://github.com/osopcloud/osop-editor)
19-
20-
## Quick Start
21-
22-
```bash
23-
# Validate the workflow
24-
pip install osop
25-
osop validate code-review-pipeline.osop.yaml
26-
27-
# Or just read the YAML — it's self-documenting
28-
cat code-review-pipeline.osop.yaml
29-
```
20+
- **Visualized** — render the workflow as a graph in the [OSOP Editor](https://osop-editor.vercel.app)
3021

3122
## How It Maps to Semantic Kernel
3223

@@ -40,6 +31,7 @@ cat code-review-pipeline.osop.yaml
4031

4132
## Learn More
4233

43-
- [OSOP Spec](https://github.com/osopcloud/osop-spec) — full specification
44-
- [OSOP Examples](https://github.com/osopcloud/osop-examples) — 30+ workflow templates
45-
- [OSOP Editor](https://github.com/osopcloud/osop-editor) — visual workflow editor
34+
- [OSOP Spec](https://github.com/Archie0125/osop-spec) — full specification
35+
- [OSOP Examples](https://github.com/Archie0125/osop-examples) — 84+ workflow templates
36+
- [OSOP Visual Editor](https://osop-editor.vercel.app) — visual workflow editor
37+
- [OSOP Website](https://osop.ai) — documentation and guides

python/samples/concepts/osop/code-review-pipeline.osop.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# in parallel, generate a structured review, post comments on GitHub,
55
# and request changes if critical issues are found.
66
#
7-
# Run with Semantic Kernel or validate: osop validate semantic-kernel-code-review.osop.yaml
7+
# Validate: osop validate code-review-pipeline.osop.yaml
88

99
osop_version: "1.0"
1010
id: "semantic-kernel-code-review"
@@ -45,13 +45,16 @@ nodes:
4545
subtype: "llm"
4646
name: "Check Test Coverage"
4747
description: "Verify new code paths have corresponding test cases."
48+
config:
49+
model: "gpt-4o"
4850

4951
- id: "generate_review"
5052
type: "agent"
5153
subtype: "llm"
5254
name: "Generate Review"
5355
description: "Synthesize all analysis into a structured review with severity levels."
5456
config:
57+
model: "gpt-4o"
5558
output_schema:
5659
summary: "string"
5760
issues: [{ file: "string", line: "int", severity: "string", message: "string" }]

0 commit comments

Comments
 (0)