fix(mcp): tear down dashboard server on cli show --kill#40968
Open
Skn0tt wants to merge 1 commit into
Open
Conversation
The --kill handler in dashboardApp.ts only called gracefullyProcessExitDoNotHang and never tore down the dashboard's HTTP/WS server. As a result DashboardConnection.onclose never fired, AttachedPage.dispose never ran, and the active screencast pipeline to the daemon-side browser was still up when the daemon then tried to gracefully close it. On Windows that race let the 30s gracefullyProcessExitDoNotHang safety timer win every time, making cli show --kill consistently take ~30s in MCP CI jobs. - DashboardServer.close() now closes WS connections before stopping the HTTP server (matches the WSServer.close() / CDPRelay.stop() pattern). - The --kill branch awaits dashboard.close() before scheduling exit. - socket.end() moves into gracefullyProcessExitDoNotHang's onExit so the cli client only sees the IPC FIN at actual process exit.
Contributor
Test results for "MCP"1 failed 7180 passed, 1113 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli show --killon the dashboard never closed the dashboard's HTTP/WS server, soDashboardConnection.onclose→AttachedPage.dispose→page.screencast.stopnever ran. The active screencast was still up when the daemon then tried to graceful-close the bound browser, and on Windows the 30sgracefullyProcessExitDoNotHangsafety timer consistently won — makingcli show --killtake ~30s in MCP CI jobs (e.g. https://github.com/microsoft/playwright/actions/runs/26235830215/job/77208610752).DashboardServer.close()now closes WS connections before stopping the HTTP server (matches theWSServer.close()/CDPRelay.stop()pattern in the repo).--killbranch awaitsdashboard.close()before scheduling exit, and movessocket.end()intogracefullyProcessExitDoNotHang'sonExitso the cli client only sees the IPC FIN at actual process exit.Follow-up to #40967 (same root-cause investigation; that one disconnects the per-tracker upstream browser connection on dispose).