fix(html-reporter): drop tag badge that duplicates the project chip#40962
Open
adityasingh2400 wants to merge 1 commit into
Open
fix(html-reporter): drop tag badge that duplicates the project chip#40962adityasingh2400 wants to merge 1 commit into
adityasingh2400 wants to merge 1 commit into
Conversation
When a test tag (e.g. @ad2) matches the active project name (e.g. project "ad2"), the HTML report rendered two identical badges side by side because ProjectAndTagLabelsView always rendered the full tag list next to the project chip. Strip any tag whose name equals the active project name (ignoring the leading @) before rendering the click view. Fixes: microsoft#40938
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ad2) matched the project name (ad2), becauseProjectAndTagLabelsViewalways rendered the fulltest.tagslist next to the project chip.@form equals the active project name before passing the list to the click view, so the duplicate disappears while non-matching tags still render.Fixes #40938